feat(sensitive): expire reviewed model invocation policy - #79
Draft
seonghobae wants to merge 3 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #10, stacked on PR #77.
Buyer/security gap
PR #77 binds sensitive-model admission to the exact route, reviewed prompt contract, reviewed output schema, and bounded input/output token budgets. Without an explicit invocation-policy lifetime, a request that matched reviewed metadata could be delayed or replayed after that review context should no longer authorize model disclosure.
Dependency
This Draft is stacked on unchanged exact PR #77 head
adb67f8de3e4828db14dfa0e2950b672b60709c5, transitively on #75 and the active sensitive-handle prerequisites. It must remain Draft while those prerequisites are active.TDD and implementation state
Test-only head
eb7daf465f35b314b175a592cdb9d74962b64800established the missing production boundary. CI run31480649072reached the intended Rust compile RED after repository contracts and formatting passed: production lacked thevalid_untilscope argument, caller-supplied trusted-time evaluator argument, andModelInvocationDecision::InvocationExpiredvariant.Production head
39ec1659541b10785fcd85a9531bdd8d823578e3implements the bounded expiry contract and passed CI run31480876883, including Rust contracts and exact Production coverage. Exact current head2ad7a2162b4842fe57f74f69f08b258f4f6a9c07adds only the truthful Unreleased changelog entry and passes exact-head CI run31481128812.The production evaluator now:
valid_until;trusted_time < valid_until;InvocationExpiredat or after the exclusive deadline; andInvocationPolicyMismatch.trusted_timeremains caller-supplied policy input from the same authoritative time domain that issuedvalid_until; this pure policy boundary reads no wall clock and does not claim clock provenance.Exact-current evidence
For exact head
2ad7a2162b4842fe57f74f69f08b258f4f6a9c07on unchanged exact baseadb67f8de3e4828db14dfa0e2950b672b60709c5:31481128812: success;31480876883: success after the intended RED cycle;No predecessor-head review, status, or mergeability result is transferred as approval for this moved head.
Truth boundary
This is deterministic invocation-metadata freshness only. It does not disclose a protected value, authenticate or invoke a provider, isolate unrelated conversation history, validate model output, enforce provider retention, execute export, choose fallback, attest a trusted clock, or close #10. Those remain separate trusted broker/orchestrator boundaries.
This PR remains Draft until its dependency stack integrates and fresh exact-head/live-base acceptance is re-established.