feat(sensitive): fail closed on unreviewed model fallback - #86
Draft
seonghobae wants to merge 6 commits into
Draft
feat(sensitive): fail closed on unreviewed model fallback#86seonghobae wants to merge 6 commits into
seonghobae wants to merge 6 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #10, stacked on PR #84.
Buyer/security gap
Issue #10 requires provider outage or route-policy mismatch to fail closed rather than silently falling back to a less trusted model. The existing sensitive-model route/invocation/output stack binds exact reviewed provider/model/region and policy metadata, but it had no separate production primitive that decides whether an alternate route may be used after the primary route becomes unavailable.
Dependency
This Draft is stacked on unchanged exact PR #84 head
62f69cadbe0b4011fec67f9e482b04c4cacf181band must remain Draft while that prerequisite and its sensitive-data stack remain active.TDD / RCA sequence
ad5696c8ee31a2f8d31a23be5c4a4aef532bb3a7established the intended fallback-policy contract before production integration.110cf838acff75e367d2c8e97ded3b16936fab61added the deterministic fallback evaluator, but CI run31493644963, Rust contracts job93785884359, failed at the locked workspace check with E0432 because the new module was not declared or exported from the crate root. The fallback implementation therefore existed but could not enter the public production boundary exercised by the integration tests.0c864d49b3b48f3dc6c5c575059c99f417b62d00added the missing module declaration and public exports. Production coverage in run31494911041, job93790084012, reached exact GREEN, while Rust contracts job93790083845correctly failed the canonical formatting gate inmodel_fallback.rs.f4ebe1efabeeb416eccbf54177e43f897f878765applied only the exact rustfmt diagnostics. CI run31495206493became fully GREEN: Rust contracts job93791058252and Production coverage job93791058330both succeeded, including repository contracts, formatting, locked workspace/all-target check, tests, strict Clippy, rustdoc, and exact owned production function/line/region/branch coverage.a2c391a5e038dc9e3d6978885d9bdd943487294fadds only the truthful Unreleased changelog entry. Fresh exact-head CI run31495714541is GREEN: Rust contracts job93792779027and Production coverage job93792779288both completed successfully with the same full contract and exact coverage gates.Implemented contract
The branch now requires:
No formal reviews or inline review threads are currently returned for this exact head. No predecessor-head check, review, mergeability result, or synthetic status is transferred to the current head.
Truth boundary
This pure policy slice does not detect provider health, authenticate or invoke a provider, disclose protected values, execute retries, choose latency/cost heuristics, persist routing state, attest region, or make an alternate model trusted.
ModelRouteAvailabilityremains caller-supplied trusted-runtime evidence; a future trusted broker/orchestrator must derive that evidence and execute only the exact route selected by this policy boundary.Keep Draft while #84 and its prerequisite sensitive-data stack remain active. This PR does not close #10; fresh exact-head/live-base acceptance is required again after any dependency movement.