feat(extension): expire managed Agent Task policy - #94
Draft
seonghobae wants to merge 3 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #27, stacked on PR #85.
Buyer/security gap
PR #85 makes Agent Task extension admission an exact managed allow-list but deliberately carries no policy freshness. A previously valid managed-extension set must not remain replayable indefinitely after enterprise policy changes.
TDD and implementation
Exact test-only head
f4521bacf98f052f275fc87d0f75c108f6e096e9established the missing freshness boundary before production changed. The tests require one explicit half-open validity window, caller-supplied trusted evaluation time, fail-closed invalid/reversed windows, not-yet-valid and expired decisions, exact-boundary expiry,u64::MAXsafety, exact extension identity matching, and preservation of the separate Agent capability boundary.Production now carries the smallest deterministic implementation:
AgentTaskExtensionPolicystoresvalid_fromandvalid_until;evaluate_agent_task_extensionreceives the trusted evaluation time; invalid windows, not-yet-valid policy and expired policy have separate typed denials; and membership is evaluated only after the freshness checks. The implementation does not read or attest a clock, so all three time values remain in one caller-attested time domain.Dependency and exact stack state
This Draft targets exact current PR #85 head
e836e833be920da8764d3dd72e058e02cd9ed72b. Exact current #94 head is66dbc574518740b8c09a558f7b54e7f5629256fe, GitHub reports it mergeable against that prerequisite, and CI run31538015144completed successfully on that exact head. No formal review or inline review thread is currently returned for the exact head. No prerequisite check or review is transferred.Keep Draft while #85/#83/#82 remain active.
Truth boundary
This slice governs only deterministic policy validity time. It does not authenticate an administrator, read Chrome enterprise policy, attest a clock, install/enable/disable extensions, verify extension signatures/update provenance, mutate profiles, grant Agent capability, authorize native messaging, persist policy, or claim managed enterprise extension support complete.