feat(evidence): bind node-state success to exact target node - #99
Draft
seonghobae wants to merge 5 commits into
Draft
feat(evidence): bind node-state success to exact target node#99seonghobae wants to merge 5 commits into
seonghobae wants to merge 5 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partial implementation of #28, stacked on exact PR #80 head
55b1421e25c5b68ca5f3b05fab37db8f4f1e22be.Buyer/correctness gap
PR #80 correctly binds
NodeStateChangedsuccess provenance to the governed target origin, but origin equality is broader than node authority. Two different semantic nodes in the same browser session/context/origin/document can both have verified same-origin provenance. Without exact node binding, an unrelated same-origin node could prove the post-condition for the governed action target.Dependency
This Draft targets PR #80 branch
feat/action-outcome-origin-bindingat unchanged exact head55b1421e25c5b68ca5f3b05fab37db8f4f1e22be; exact compare for current head reportsbehind_by=0with merge base equal to that prerequisite. Keep Draft while #80/#64 remain active. No prerequisite check, review, status, or mergeability evidence is transferred.TDD / RCA sequence
e88e53a4945a0a745fac303b8bcfb980af2bfef3required an OriginWeaveObservedNodeHandle-bound node-state evidence path. CI run31550541187, Rust contracts job93972106904, passed repository contracts and canonical formatting, then failed at the intended workspace/production boundary because the new node-bound API did not exist.NodeStateChanged, whilenew_node_staterequires the exact governed target node and independently observed node to be identical across browser session, browsing context, canonical origin, document epoch, and node identifier. Existing verified-provenance and monotonic-order checks remain prerequisites.59f9893c68cdd8b454f1500dab4f190ad3510c56passed Rust contracts, tests, strict Clippy, and rustdoc, but exact coverage correctly failed at one uncovered error-propagation region innew_node_state(action_outcome.rs:145). The focused follow-up therefore exercised unverified node-state provenance through that exact public path rather than weakening or excluding the gate.8ec18b8701104cf3f3764334601c69c1497297b9contains that realistic coverage regression only.Implemented contract
VerifiedActionOutcomeEvidencenow:NodeStateChangedthrough the generic constructor asNodeStateTargetRequired, preventing origin-only evidence from bypassing node identity;new_node_statefor exact node-state evidence;PostConditionNodeMismatch; andObservedNodeHandlefor node-state evidence while non-node evidence exposes no false node identity.Exact-head proof
On unchanged exact head
8ec18b8701104cf3f3764334601c69c1497297b9against unchanged exact prerequisite #80 head55b1421e25c5b68ca5f3b05fab37db8f4f1e22be:31551314274: success;93974393944: repository contracts, canonical formatting, locked workspace/all-target check, full tests, strict Clippy, and rustdoc all success;93974393956: exact owned production function/line/region/branch enforcement success;No predecessor-head result is promoted as current proof.
Truth boundary
This slice is an evidence-construction invariant only. It does not authenticate a browser adapter, dispatch input, prove that adapter-supplied node observations are truthful, observe a post-condition itself, authorize an action, attest a clock, persist evidence, or complete the Chromium vertical slice. Exact node identity remains OriginWeave-owned authority that a trusted adapter/runtime must supply immediately around real dispatch and observation.