chore: superseded by current-base KPI PR #338

[seonghobae]

Superseded by clean current-base reconstruction

Closed in favor of PR #338.

PR #338 reconstructs this exact five-file terminal-outcome KPI delta directly on protected main 55d7ae8647208e301f282350f076eeddaba61d11. Fresh blob verification proves all outputs are byte-identical to this predecessor head:

• KpiSnapshotRecord.java: 5a91a33effc2bd81f756d8a54cac71650b074552;
• KpiSnapshotExportResponse.java: b5c40a2951300c1ae995aba5cddda2a07829f93c;
• KpiSnapshotResponse.java: fe0e4f5ebf49a955f7be9313b9b3b48036af98fd;
• KpiSnapshotResponseTest.java: eba5afc202051c8db853a65fc4235fd91a4abb28;
• AnalyticsControllerTest.java: da895f917221072325d6a11933b0428766ba946e.

Replacement head 65cf2956ad69614cabbb1369b010b1278b06ab3a is GREEN on CI 31389258830, Security Scan 31389258832, SAST 31389258776, and fuzz 31389258688; auto-merge is enabled through normal protection.

Keeping both PRs would duplicate identical semantics, path ownership, checks, and review traffic. Issue #327 remains open until the protected replacement integrates; issue #326 and issue #329 remain separate.

[coderabbitai]

📝 Walkthrough

Walkthrough

전환 성공률의 분모를 전체 작업 수에서 종료된 성공·실패 작업 수로 변경했습니다. 종료된 작업이 없으면 0.0을 반환합니다. 관련 문서와 테스트 기대값을 갱신했습니다.

Changes

전환 성공률 계산

Layer / File(s)	Summary
계산 기준 및 문서 갱신 src/main/java/com/clearfolio/viewer/analytics/KpiSnapshotRecord.java, src/main/java/com/clearfolio/viewer/api/KpiSnapshotExportResponse.java, src/main/java/com/clearfolio/viewer/api/KpiSnapshotResponse.java	conversionSuccessRate가 succeeded + failed를 분모로 사용합니다. 종료된 작업이 없으면 0.0을 반환합니다. 관련 Javadoc도 갱신했습니다.
계산 검증 테스트 src/test/java/com/clearfolio/viewer/api/KpiSnapshotResponseTest.java, src/test/java/com/clearfolio/viewer/controller/AnalyticsControllerTest.java	성공·실패·제출·처리 중 작업을 포함한 성공률과 종료 작업이 없는 경우를 검증합니다. 컨트롤러 테스트 기대값을 0.5로 변경했습니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related issues

• clearfolio issue 327: 처리 중 작업을 제외하도록 conversionSuccessRate의 분모를 변경하는 내용과 관련됩니다.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 conversionSuccessRate의 성공률 계산 기준을 종료 상태 결과로 변경한 주요 변경 사항을 정확하고 간결하게 설명합니다.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/terminal-conversion-success-rate

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

@opencode-agent @cwl-noema-review Please independently review exact current head 99e7c79142ce8e10ad0ef6880ab6d4fa8826c113 against protected main 83ec6f7fe2b04bdcd28bf98ec350e41e55730a18. Exact-head CI 31377819670, Security Scan 31377819586, SAST Semgrep 31377819607, and fuzz 31377819610 are successful; no inline review thread is currently returned. Verify the actual bounded KPI semantic change and tests: in-flight SUBMITTED/PROCESSING jobs must not depress conversionSuccessRate, the denominator must be terminal SUCCEEDED+FAILED outcomes, no-terminal state must remain deterministic 0.0, controller integration must use the same contract, and public KPI snapshot/export Javadocs must not retain the superseded all-jobs definition. Submit a formal review only for this exact head if supported by current evidence; do not mutate the branch, merge, or weaken gates.

[seonghobae]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[seonghobae]

@coderabbitai review

Please review exact current head 99e7c79142ce8e10ad0ef6880ab6d4fa8826c113. Focus on terminal-outcome denominator semantics across response, controller, persisted/exported evidence, and zero-terminal behavior. Treat predecessor-head evidence as historical.

[coderabbitai]

@seonghobae I will review pull request #328 at 99e7c79142ce8e10ad0ef6880ab6d4fa8826c113. I will treat predecessor-head results as historical and focus on the requested KPI contract.

⚠️ Action not completed

Already reviewed.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.