Skip to content

chore: superseded by clean HMAC-readiness PR #313 - #333

Closed
seonghobae wants to merge 3 commits into
mainfrom
fix/production-hmac-readiness-main
Closed

chore: superseded by clean HMAC-readiness PR #313#333
seonghobae wants to merge 3 commits into
mainfrom
fix/production-hmac-readiness-main

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

Superseded duplicate

Closed in favor of PR #313.

Fresh comparison proves both branches are clean reconstructions from protected main 55d7ae8647208e301f282350f076eeddaba61d11 and carry the same production blob af989ab08a026418cf31fb7693316a65a84f77e2. Their tests differ only in the descriptive null-secret test method name; both exercise the same controlled missing-secret boundary.

PR #313 exact head 610f081cc56cfcaa372d674a56f4b21c91123c8f is already Ready, mergeable, auto-merge enabled, and GREEN on CI 31387412055, Security Scan 31387411478, SAST 31387411422, and fuzz 31387412079. Keeping both PRs would duplicate writer ownership, checks, review requests, and merge risk without adding product behavior.

This closure does not mark issue #319 complete. Runtime credential-registry migration remains separate from bounded HMAC readiness.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 8 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 88526077-8b02-455e-961f-dcaa1511cc54

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 100171a.

📒 Files selected for processing (2)
  • src/main/java/com/clearfolio/viewer/config/ProductionAuthReadinessConfig.java
  • src/test/java/com/clearfolio/viewer/config/ProductionAuthReadinessConfigTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 10, 2026 12:05
@seonghobae seonghobae changed the title fix(security): reconcile HMAC readiness after #270 chore: superseded by clean HMAC-readiness PR #313 Aug 10, 2026
@seonghobae seonghobae closed this Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant