chore: superseded by clean availability PR #295

[seonghobae]

Superseded duplicate

Closed in favor of PR #295.

Fresh blob comparison proves #335 and #295 carry the same production HealthController blob dcdca47b8113c3c3431663c1432361d40d7b6634 and the same HealthControllerTest blob f6cc1b7a03be643728af8ed9c376ff68535aa479 on protected baseline 55d7ae8647208e301f282350f076eeddaba61d11.

PR #295 additionally contains the path-local operations and rollback guide, explicitly delegates canonical decision authority to ADR-0006 instead of creating a competing ADR, and is already Ready, mergeable, auto-merge enabled, and GREEN on CI 31388207104, Security Scan 31388207985, SAST 31388207139, and fuzz 31388207812.

Keeping #335 would duplicate exact source/test ownership, checks, and review traffic without adding behavior.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1d50f0b5-c1af-4a09-bc98-8bab883aebc9

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 285c56a.

📒 Files selected for processing (2)

• src/main/java/com/clearfolio/viewer/controller/HealthController.java
• src/test/java/com/clearfolio/viewer/controller/HealthControllerTest.java

---

📝 Walkthrough

Walkthrough

HealthController가 ApplicationAvailability를 사용해 liveness 및 readiness 프로브를 제공합니다. 각 프로브는 상태에 따라 200 또는 503을 반환하며, 응답에 no-store 캐시 정책을 적용합니다. 테스트는 정상·비정상 상태와 null 의존성을 검증합니다.

Changes

헬스 프로브

Layer / File(s)	Summary
가용성 의존성 계약 src/main/java/com/clearfolio/viewer/controller/HealthController.java	HealthController가 ApplicationAvailability를 생성자에서 주입받습니다. null 의존성은 거부합니다.
프로브 엔드포인트 처리 src/main/java/com/clearfolio/viewer/controller/HealthController.java	/healthz는 liveness 상태를 확인하고 ok 또는 broken을 반환합니다. /readyz는 readiness 상태를 확인하고 ready 또는 not_ready를 반환합니다. 실패 응답은 503이며 모든 응답은 no-store를 사용합니다.
프로브 응답 검증 src/test/java/com/clearfolio/viewer/controller/HealthControllerTest.java	WebTestClient와 mock availability를 사용해 정상·비정상 응답의 본문, 상태 코드, Cache-Control 헤더 및 null 생성자 검증을 추가합니다.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant WebTestClient
  participant HealthController
  participant ApplicationAvailability
  WebTestClient->>HealthController: GET /healthz 또는 /readyz
  HealthController->>ApplicationAvailability: 상태 조회
  ApplicationAvailability-->>HealthController: LivenessState 또는 ReadinessState
  HealthController-->>WebTestClient: JSON 상태 본문과 200 또는 503 응답

Loading

Possibly related PRs

• ContextualWisdomLab/clearfolio#265: 동일한 HealthController liveness/readiness 프로브 변경을 구현합니다.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	제목은 /healthz와 /readyz의 liveness/readiness 조정 및 #270 이후 재구성이라는 주요 변경을 간결하게 설명합니다.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch feat/liveness-readiness-main

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}