feat(lifecycle): define durable deletion state vocabulary - #351
feat(lifecycle): define durable deletion state vocabulary#351seonghobae wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 23 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Objective
Reconcile the durable deletion lifecycle state vocabulary from stale descendant #268 onto the exact current protected-main baseline as a path-disjoint prerequisite for issue #263 deletion receipts/recovery.
Test-first state
This Draft starts intentionally RED at exact test-only head
cfbd077582a64c3417ec1211cab4cba4dcba7cec.ArtifactDeletionStateTestrequires exactly the five monotonic states already specified by issue #263:DELETION_REQUESTED,METADATA_TOMBSTONED,ARTIFACT_CLEANUP_PENDING,ARTIFACT_CLEANUP_COMPLETED, andARTIFACT_CLEANUP_FAILED. Protected main does not contain the production enum, so Maven test compilation is expected to fail until the bounded production vocabulary is restored.Scope
This slice adds only the lifecycle state model and its focused regression. It does not copy #268's stale receipt ledger/coordinator, admin controller, repository, artifact-store, audit, workflow or documentation changes; it does not overlap #350's lock-registry path. Durable receipt persistence, generation binding, retry/recovery and user-facing deletion semantics remain open under #263/#312.
Acceptance
Observe exact-head RED -> add only the production enum -> exact-head
mvn -B --no-transfer-progress verify/ zero missed owned production coverage / public Javadocs -> CI/Security Scan/SAST/fuzz -> current reviews/threads/base refetch. Keep Draft until GREEN exact-head evidence exists; qualifying independent write-authorized approval remains a separate merge gate.