Skip to content

feat(lifecycle): define durable deletion state vocabulary - #351

Open
seonghobae wants to merge 2 commits into
mainfrom
feat/deletion-lifecycle-state-main-20260811
Open

feat(lifecycle): define durable deletion state vocabulary#351
seonghobae wants to merge 2 commits into
mainfrom
feat/deletion-lifecycle-state-main-20260811

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Objective

Reconcile the durable deletion lifecycle state vocabulary from stale descendant #268 onto the exact current protected-main baseline as a path-disjoint prerequisite for issue #263 deletion receipts/recovery.

Test-first state

This Draft starts intentionally RED at exact test-only head cfbd077582a64c3417ec1211cab4cba4dcba7cec. ArtifactDeletionStateTest requires exactly the five monotonic states already specified by issue #263: DELETION_REQUESTED, METADATA_TOMBSTONED, ARTIFACT_CLEANUP_PENDING, ARTIFACT_CLEANUP_COMPLETED, and ARTIFACT_CLEANUP_FAILED. Protected main does not contain the production enum, so Maven test compilation is expected to fail until the bounded production vocabulary is restored.

Scope

This slice adds only the lifecycle state model and its focused regression. It does not copy #268's stale receipt ledger/coordinator, admin controller, repository, artifact-store, audit, workflow or documentation changes; it does not overlap #350's lock-registry path. Durable receipt persistence, generation binding, retry/recovery and user-facing deletion semantics remain open under #263/#312.

Acceptance

Observe exact-head RED -> add only the production enum -> exact-head mvn -B --no-transfer-progress verify / zero missed owned production coverage / public Javadocs -> CI/Security Scan/SAST/fuzz -> current reviews/threads/base refetch. Keep Draft until GREEN exact-head evidence exists; qualifying independent write-authorized approval remains a separate merge gate.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 23 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 82c8787a-1789-45ba-85a5-6504e3afe192

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 70bdf52.

📒 Files selected for processing (2)
  • src/main/java/com/clearfolio/viewer/lifecycle/ArtifactDeletionState.java
  • src/test/java/com/clearfolio/viewer/lifecycle/ArtifactDeletionStateTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 10, 2026 17:01
@seonghobae
seonghobae enabled auto-merge (squash) August 10, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant