feat(security): add standalone directory credential registry - #354
Draft
seonghobae wants to merge 4 commits into
Draft
feat(security): add standalone directory credential registry#354seonghobae wants to merge 4 commits into
seonghobae wants to merge 4 commits into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Advance issue #319 with a standalone, provider-neutral local credential-store adapter on top of the exact #344 credential-registry contract. The adapter resolves purpose-scoped, versioned key material without making raw environment variables the long-lived runtime authority.
Exact stack state
f7335f979eca75b125199760b4f7dc538733b8b0;7fe3fb8124bded7f8449ac741fd1339192d0bc5f;main:55d7ae8647208e301f282350f076eeddaba61d11;RED -> GREEN evidence
f52132c8c55e37bbf2e2e4c9c4d92fbb5cf9ab84: CI run31422870920, Maven job93567572945, exact-head checkout verified andtestCompilefailed at the intentionally missingDirectoryCredentialRegistryproduction type.4a46161a2bab0a090c5af8bd4fec23ee1273e765: all 508 tests passed with zero failures/errors/skips, but CI correctly failed the exact 100% branch-coverage gate with one uncovered metadata-validation branch atDirectoryCredentialRegistry.java:111.7fe3fb8124bded7f8449ac741fd1339192d0bc5f: exact-head CI run31423352276completed successfully. Maven test job93569129336, buyer-readiness job93569129423, and Maven merge-compatibility job93569129500all succeeded; exact-head fuzz run31423352066also succeeded.The adapter now requires:
<root>/<credential>/purpose;<root>/<credential>/active-version;<root>/<credential>/versions/<version>.key;Scope boundary
This slice is a read-only standalone adapter foundation. It does not migrate
TenantAccessService,ArtifactLinkService, Spring configuration, production bootstrap, or #313ProductionAuthReadinessConfig; it does not implement credential writes, automatic rotation windows, distributed cache, encryption/KMS custody, or a vendor-specific secret-manager adapter. Environment/config HMAC authority remains an open production gap until later migration slices route runtime consumers through the registry.Security Scan/SAST evidence is not inferred from the stacked PR because those workflows were not returned for this exact child head; absent evidence is not passing evidence. Before any eventual protected-main merge, integrate #344 first, rebuild/reconcile this unique child delta onto the new exact protected base, and regenerate every required base-sensitive CI/security/review gate. No raw key material may enter logs, exceptions, PR metadata, telemetry, SBOM, or provenance.