feat(auth): define explicit issuer trust policy - #364
Draft
seonghobae wants to merge 4 commits into
Draft
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Advance issue #314 with a path-disjoint trust-profile value object stacked on #343. A provider-specific verifier must receive server-owned issuer, audience, and algorithm policy rather than deriving trust from an untrusted bearer credential.
Test-first state
This Draft starts intentionally RED at test-only head
2442db427b475f38d6c8a58239ae622cdcbb06cb.IssuerTrustPolicyTestrequires an immutable policy with explicit HTTPS issuer, audience, and non-empty algorithm allowlist; it rejects missing/ambiguous issuer authority and implicit/unsafe algorithm policy. The production type does not exist at this head, so Maven test compilation is expected to fail at that exact boundary.Stack and scope
Base is #343 exact head
bc4418b4d1a88adcb73c07da61876414d49aac30(feat/identity-verifier-contract-main-20260811), which remains directly based on protectedmain55d7ae8647208e301f282350f076eeddaba61d11. This child adds only the server-owned issuer trust-policy model and focused tests. It does not parse JWTs, perform OIDC discovery/JWK retrieval, introspect opaque tokens, map roles, change controllers, or replace existing signed tenant-header auth.Acceptance
Observe exact-head RED -> add the smallest production policy implementation -> exact-head Maven/coverage/Javadoc acceptance and directly emitted CI/security evidence. Keep Draft while #343 is open. After #343 integrates, reconcile this unique delta onto the new protected base and regenerate base-sensitive checks/reviews before final merge. Independent write-authorized approval remains a separate protected-merge gate.