Skip to content

feat(durable): define generation-bound conversion outbox record - #368

Open
seonghobae wants to merge 2 commits into
mainfrom
feat/conversion-outbox-record-main-20260811
Open

feat(durable): define generation-bound conversion outbox record#368
seonghobae wants to merge 2 commits into
mainfrom
feat/conversion-outbox-record-main-20260811

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Objective

Advance issue #312 in the required persisted-acceptance/outbox direction with one path-disjoint durable-domain primitive. An accepted dispatch record must bind an exact job generation, preserve the original acceptance identity, and record broker dispatch monotonically without allowing a dispatch timestamp to predate durable acceptance.

Exact test-first evidence

Protected main remains exact 55d7ae8647208e301f282350f076eeddaba61d11.

  • RED test-only head 0667e9412e65205f48833f197f0eea79b710d837: CI run 31447254699, Maven job 93644021484, exact checkout verified and testCompile failed because ConversionOutboxRecord did not exist.
  • GREEN head 423171b762a7e4457e1ce1bc3bacf5f177a3a937: exact-head CI 31447341116, Security Scan 31447341128, SAST Semgrep 31447341110, and fuzz 31447341118 all completed successfully.

The immutable record binds outbox dispatch to an exact accepted job generation, rejects dispatch timestamps before acceptance, and makes repeated dispatch acknowledgement idempotent without changing the first durable dispatch timestamp.

Scope

New durable-domain outbox record plus focused tests only. This does not yet persist the outbox, make job+outbox acceptance atomic, dispatch to a broker, implement idempotency storage, worker claims, retry scheduling, cancellation, or change HTTP acceptance semantics. It does not duplicate the active idempotency lane owned by another current writer.

Issue #312 remains open for persistence/atomic acceptance/idempotency, worker leasing, durable retries, backpressure, cancellation, restart/redelivery acceptance, telemetry and integrated release evidence.

Merge gate

Ready for ordinary independent review. Merge only if this unchanged exact head continues to satisfy all live required checks, zero valid unresolved findings, current protected-base expectations, and the counted approving review from an independent reviewer with write access required by repository policy. Automated checks/comments/model output are evidence, not approval.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b96bff77-3cb2-4abb-ba05-8b4b1d4169b8

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 423171b.

📒 Files selected for processing (2)
  • src/main/java/com/clearfolio/viewer/durable/ConversionOutboxRecord.java
  • src/test/java/com/clearfolio/viewer/durable/ConversionOutboxRecordTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant