Skip to content

feat(durable): define generation-fenced cancellation race record - #370

Open
seonghobae wants to merge 3 commits into
mainfrom
feat/conversion-cancellation-record-main-20260811
Open

feat(durable): define generation-fenced cancellation race record#370
seonghobae wants to merge 3 commits into
mainfrom
feat/conversion-cancellation-record-main-20260811

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Objective

Advance issue #312's versioned cancellation semantics with one path-disjoint durable-domain state machine. A cancellation request must bind server-authoritative tenant/job/generation identity, and the cancellation-vs-completion race must resolve monotonically so a terminal winner cannot later be rewritten by a stale opposite outcome.

Test-first state

This Draft starts intentionally RED at exact test-only head a4312bf3b0305dc92bafc0b1efcc3f29e4cd50d9 on protected main 55d7ae8647208e301f282350f076eeddaba61d11. ConversionCancellationRecordTest requires tenant/job/generation/request identity, normalized bounded tenant authority, exact generation fencing, monotonic cancellation-vs-completion winner semantics, idempotent repeated terminal acknowledgement, and fail-closed timestamps/inputs. The production types do not exist at this head, so Maven test compilation is expected to fail at that exact boundary.

Scope

New durable-domain cancellation state/record plus focused tests only. This does not yet persist cancellation requests, expose an HTTP endpoint, terminate a converter process, wire worker lease fencing, change the current job status model, or claim issue #312 completion. It does not overlap the active viewer/pdf.js resource-cancellation PR.

Acceptance

Observe exact-head RED -> smallest immutable production implementation -> exact-head mvn -B --no-transfer-progress verify with zero missed owned production coverage/public Javadocs -> CI/Security Scan/SAST/fuzz -> current reviews/threads/live-base refetch. Keep Draft until GREEN exact-head evidence exists. Independent write-authorized approval remains a separate protected-merge gate.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 39 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ae6c4696-ab47-4138-82b9-944fc3716f94

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and b320821.

📒 Files selected for processing (3)
  • src/main/java/com/clearfolio/viewer/durable/ConversionCancellationRecord.java
  • src/main/java/com/clearfolio/viewer/durable/ConversionCancellationState.java
  • src/test/java/com/clearfolio/viewer/durable/ConversionCancellationRecordTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant