Skip to content

fix(viewer): report only qualified renderer metadata - #386

Open
seonghobae wants to merge 3 commits into
mainfrom
fix/viewer-bootstrap-renderer-truth-main-20260811
Open

fix(viewer): report only qualified renderer metadata#386
seonghobae wants to merge 3 commits into
mainfrom
fix/viewer-bootstrap-renderer-truth-main-20260811

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Objective

Remove misleading production viewer-bootstrap adapter claims. Protected main currently reports DOCX_PREVIEW, SHEET_ADAPTER, SLIDE_ADAPTER, and TEXT_ADAPTER based only on the source filename even though the shipped viewer renders the converted PDF through PDF.js and transformed-format production conversion fails closed when no qualified converter is configured.

Test-first state

This Draft starts intentionally RED at exact test-only head ce9be547a3a3e0e9cddffbd6899f5e91b355615f, directly based on protected main 55d7ae8647208e301f282350f076eeddaba61d11.

ViewerBootstrapResponseTest now requires the bootstrap to report only the actually qualified PDF_JS renderer while preserving normalized source-extension metadata. Protected main still synthesizes unqualified source-family adapter names, so the focused test is expected to fail before production repair.

Scope

Bounded viewer-bootstrap product-truth fix under issue #317 and the fail-closed fidelity boundary of issue #5. It does not change Office conversion, PDF.js runtime code, viewer/session authentication, demo.js/dom-utils.js, tenant lifecycle, OpenAPI, credential/OIDC work, or canonical documentation owned by active PR #305.

Acceptance

Observe exact-head RED -> smallest production mapping repair -> focused/full mvn -B --no-transfer-progress verify with exact 100% owned production coverage and warning-free public Javadocs -> CI/Security Scan/SAST/fuzz -> current reviews/threads/live-base refetch. Keep Draft until exact-head GREEN evidence exists. Qualifying independent non-author approval remains a separate protected-merge gate.

Summary by CodeRabbit

  • 변경 사항
    • 문서, 스프레드시트, 프레젠테이션, 텍스트 파일을 포함한 모든 지원 파일 형식이 PDF 기반 뷰어로 표시됩니다.
    • 뷰어 응답 및 별칭 경로에서도 일관되게 PDF 뷰어가 사용됩니다.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 702895ae-4607-4dc1-8e1a-8c9b2ce48164

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 5198e2d.

📒 Files selected for processing (3)
  • src/main/java/com/clearfolio/viewer/api/ViewerBootstrapResponse.java
  • src/test/java/com/clearfolio/viewer/api/ViewerBootstrapResponseTest.java
  • src/test/java/com/clearfolio/viewer/controller/ConversionControllerTest.java

📝 Walkthrough

Walkthrough

ViewerBootstrapResponse는 원본 파일 확장자별 어댑터 매핑을 제거하고 rendererAdapter에 항상 PDF_JS를 설정합니다. 관련 API 및 컨트롤러 테스트도 새 응답값을 검증하도록 변경되었습니다.

Changes

렌더러 어댑터 변경

Layer / File(s) Summary
PDF_JS 렌더러 어댑터 적용
src/main/java/com/clearfolio/viewer/api/ViewerBootstrapResponse.java
rendererAdapter 설명을 qualified renderer 기준으로 변경하고, 응답 생성 시 항상 PDF_JS를 설정합니다.
렌더러 어댑터 검증 갱신
src/test/java/com/clearfolio/viewer/api/ViewerBootstrapResponseTest.java, src/test/java/com/clearfolio/viewer/controller/ConversionControllerTest.java
확장자별 응답, 공백 또는 대문자 DOCX 파일명, 일반 및 별칭 경로 응답이 PDF_JS를 사용하도록 기대값을 변경합니다.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 뷰어 메타데이터가 검증된 렌더러 정보만 보고하도록 수정한 PR의 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/viewer-bootstrap-renderer-truth-main-20260811

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 13:17
@seonghobae
seonghobae enabled auto-merge (squash) August 11, 2026 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant