fix(accessibility): make focus appearance contrast-robust - #390
Closed
seonghobae wants to merge 1 commit into
Closed
fix(accessibility): make focus appearance contrast-robust#390seonghobae wants to merge 1 commit into
seonghobae wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Advance issue #324 by giving keyboard focus a deterministic qualifying indicator on both light and dark surfaces. This is a current-protected-base reconstruction of the unique semantic delta preserved on stale branches
fix/focus-appearance-contrast/fix/focus-appearance-main, which are behind protected main and have no open PR.Test-first state
This Draft starts intentionally RED at exact test-only head
4868211b03dc86627b2c0a716b5b0f91bd00cad1, directly based on protectedmain55d7ae8647208e301f282350f076eeddaba61d11.scripts/test_viewer_focus_appearance.pyparses the actual:focus-visiblerule, resolves the current limited color syntax, computes WCAG relative-luminance contrast, and requires at least a 2px qualifying band at 3:1 against both white and black backgrounds. Protected main's single modern-browser lightened coral outline is expected to fail the dark/light robustness contract.Scope
Bounded CSS/accessibility slice under #324. It does not touch
viewer.jsgeneration safety (#322/#323),demo.js/dom-utils.js(#264), Java/controller work, or canonical documentation owned by #305.Acceptance
Observe exact-head RED, apply the smallest two-tone focus rule reconstructed onto current main, then require script tests plus full exact-head CI/Security Scan/SAST/fuzz, zero valid unresolved findings, fresh exact-head/live-base identity, and qualifying independent approval where live protection requires it.