🛡️ Sentinel: [CRITICAL] AdminController 엔드포인트 인증 누락 수정

[seonghobae]

AdminController 엔드포인트에 보안 인증(테넌트 접근 제어)이 누락된 취약점을 수정했습니다. TenantAccessService를 주입하고, 모든 API 메서드에서 admin:access 권한을 강제하도록 구현했습니다.

---

PR created automatically by Jules for task 12084739371566648687 started by @seonghobae

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 46 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 3d1a011a-b6c7-49a9-9377-081fe8b3f828

📥 Commits

Reviewing files that changed from the base of the PR and between 55d7ae8 and 46a6d66.

📒 Files selected for processing (4)

• .jules/sentinel.md
• src/main/java/com/clearfolio/viewer/auth/TenantPermissions.java
• src/main/java/com/clearfolio/viewer/controller/AdminController.java
• src/test/java/com/clearfolio/viewer/controller/AdminControllerTest.java

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[seonghobae]

Closing as technically unsafe/competing work rather than merging a partial authorization layer. On exact head 46a6d664bace076abe0a14c864638bc3f57e6b5c against protected main 55d7ae8647208e301f282350f076eeddaba61d11, this change introduces a new broad admin:access permission but still calls the global getAllJobs(), global deleteJob(jobId), and global retryDeadLettered(jobId, "admin") paths. That does not establish same-tenant object authority and directly conflicts with the accepted #263 contract, which requires tenant-scoped output, non-enumerating cross-tenant behavior, and dedicated least-privilege permissions; #263 specifically requires admin:write for administrative deletion. Active PR #341 already owns the current AdminController deletion path and uses job:delete plus deleteJob(jobId, TenantContext) with missing/foreign concealment. A correct follow-up for admin list/retry must be reconstructed path-disjointly after the active controller owner is integrated or reconciled, using storage/service-scoped tenant authority and the accepted permission vocabulary rather than preserving these global operations.

[google-labs-jules]

Closing as technically unsafe/competing work rather than merging a partial authorization layer. On exact head 46a6d664bace076abe0a14c864638bc3f57e6b5c against protected main 55d7ae8647208e301f282350f076eeddaba61d11, this change introduces a new broad admin:access permission but still calls the global getAllJobs(), global deleteJob(jobId), and global retryDeadLettered(jobId, "admin") paths. That does not establish same-tenant object authority and directly conflicts with the accepted #263 contract, which requires tenant-scoped output, non-enumerating cross-tenant behavior, and dedicated least-privilege permissions; #263 specifically requires admin:write for administrative deletion. Active PR #341 already owns the current AdminController deletion path and uses job:delete plus deleteJob(jobId, TenantContext) with missing/foreign concealment. A correct follow-up for admin list/retry must be reconstructed path-disjointly after the active controller owner is integrated or reconciled, using storage/service-scoped tenant authority and the accepted permission vocabulary rather than preserving these global operations.

알겠습니다. 기존 작업과 충돌하며 보안 요구사항에 부합하지 않아 작업이 중단 및 PR이 닫히는 것을 이해했습니다. 이에 따라 작업을 중단하겠습니다.