Skip to content

fix(logging): remove duplicate Commons Logging on current main - #411

Open
seonghobae wants to merge 3 commits into
mainfrom
fix/single-commons-logging-binding-main-20260812-r2
Open

fix(logging): remove duplicate Commons Logging on current main#411
seonghobae wants to merge 3 commits into
mainfrom
fix/single-commons-logging-binding-main-20260812-r2

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Objective

Reconstruct #340's single-runtime-provider logging repair directly on current protected main after #264 advanced the baseline, without stale ancestry.

Test-first current-base state

  • protected base: b66b692ce580b783cddf9e99d96c4f94aa6b1735;
  • exact test-only head: 0c2f7bcf018861eed4f7ff7d05cc9c4fc8e4773c;
  • current runtime still carries both Spring spring-jcl and standalone commons-logging through PDFBox, and current CI emits the duplicate-provider warning;
  • Java regression requires exactly one LogFactory.class provider owned by spring-jcl;
  • deterministic repository contract requires PDFBox's commons-logging:commons-logging exclusion, rejects direct reintroduction, and remains discoverable under standard-library unittest.

This Draft intentionally begins RED. Observe exact-head failure before changing pom.xml; then apply only the PDFBox exclusion and require exact-head Maven/100% coverage/Javadocs plus CI/Security/SAST/fuzz and fresh reviews/threads.

Scope

Three-file runtime/dependency-integrity slice only. It does not change application logging semantics, backend selection, source conversion, release publication, or canonical docs. PR #340 is the stale-base predecessor and is superseded by this current-base reconstruction.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: ba9aa871-72cd-4824-97cb-9c56295afb64

📥 Commits

Reviewing files that changed from the base of the PR and between b66b692 and 90fa867.

📒 Files selected for processing (3)
  • pom.xml
  • scripts/test_commons_logging_dependency_contract.py
  • src/test/java/com/clearfolio/viewer/config/CommonsLoggingRuntimeBindingTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 12, 2026 05:36
@seonghobae
seonghobae enabled auto-merge (squash) August 12, 2026 05:37

Copy link
Copy Markdown
Collaborator Author

@opencode-agent review

Please review the unchanged exact current head 90fa86783b430412541c36444ace069515023742 against live protected main and repository gates. Treat checks/model output as evidence only and submit a formal review only for this exact head.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant