fix(accessibility): preserve context for empty root names - #416
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthrough
ChangesRoot 표시 이름 처리
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
seonghobae
marked this pull request as ready for review
August 11, 2026 05:34
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Current-protected-base successor to historical PR #414. A filesystem root can expose an empty
File.getName(), producing empty<title>and<h1>elements and removing page context for assistive technology.Test-first evidence
master@2dce93d1ec32ca6da50b05ecdad301ecfcd0bc8d;ee6bc00cc54ed6981aaca7bd715b1e6ab6c23fd4;31460788515, job93683712857; 68 tests ran and onlytestProcessDirEmptyNameFallbackfailed because title/heading were empty;0f57e118249bb30a51f5b41593e3ec03df37afae;directoryNamewith"Root"fallback and use it for both title and heading;31461182262;31461182126;31461182145.Scope and lineage
Only
src/main/kotlin/html4tree/main.ktandsrc/test/kotlin/html4tree/MainTest.ktchange. Historical PR #414 is superseded; none of its predecessor evidence was reused. The current head is two commits ahead and zero behind the independently resolved protected base.Summary by CodeRabbit
버그 수정
Root가 표시됩니다.테스트
Root인지 검증하는 테스트를 추가했습니다.