Skip to content

fix(a11y): wrap long directory headings - #419

Merged
seonghobae merged 3 commits into
masterfrom
fix/long-heading-wrap-current
Aug 11, 2026
Merged

fix(a11y): wrap long directory headings#419
seonghobae merged 3 commits into
masterfrom
fix/long-heading-wrap-current

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Collaborator

Purpose

Rebuild the unique accessibility behavior from stale PR #411 on current protected master. File links already wrap, but an unbroken directory name in the generated h1 can overflow a narrow viewport.

Test-first evidence

  • Invalid first attempt: test-only head 18a344737c99b0434e43869ecda6f62cf3bd2c9c produced CI run 31465482084, but its test regex was malformed and raised PatternSyntaxException. That run is test-infrastructure evidence only and is not the product RED oracle.
  • Valid RED: corrected test-only head 1248c8cf1fdff74831bffa9a4a8d4e4c71f3e75e ran CI 31473152488 / job 93720775196: 74 tests executed with exactly one intended failure at MainTest.kt:360, proving the generated stylesheet lacked the h1 { overflow-wrap: anywhere; } rule.
  • Narrow fix: exact head 0fb29e60a50c11856aea1c74e6e319befef046da adds only that heading-wrap rule while retaining the focused regression test.

Exact-head verification

Protected-base snapshot and independently resolved live master are both a801bc3b4b4dbc08919dbf02c93477c0cbfd4309.

  • CI 31474207096 / build job 93724052789: success, including Gradle tests and JaCoCo verification.
  • SAST Semgrep 31474207106 / job 93724053281: success.
  • Security Scan 31474207157: Scorecard 93724055938, OSV 93724055959, Trivy 93724056001, and dependency review 93724056033 all succeeded.
  • Current-head reviews: none; review threads: none.

Claim boundary

This fixes wrapping for generated directory headings. It does not claim whole-product WCAG conformance or independently validate every browser zoom, font, localization, or assistive-technology combination.

Summary by CodeRabbit

  • 개선 사항

    • 좁은 화면에서도 긴 디렉터리 제목이 적절히 줄바꿈되어 화면 밖으로 넘치지 않도록 개선했습니다.
  • 테스트

    • 긴 제목의 줄바꿈 동작을 자동으로 검증하는 테스트를 추가했습니다.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 51c3b997-8d5f-48c6-8c29-c8cf1b5139af

📥 Commits

Reviewing files that changed from the base of the PR and between a801bc3 and 0fb29e6.

📒 Files selected for processing (2)
  • src/main/kotlin/html4tree/main.kt
  • src/test/kotlin/html4tree/MainTest.kt

📝 Walkthrough

Walkthrough

생성된 HTML의 h1 요소에 overflow-wrap: anywhere 스타일을 추가했습니다. testProcessDir는 생성된 HTML에 해당 스타일이 포함되는지 검증합니다.

Changes

제목 줄바꿈

Layer / File(s) Summary
h1 줄바꿈 스타일 및 검증
src/main/kotlin/html4tree/main.kt, src/test/kotlin/html4tree/MainTest.kt
생성된 h1 스타일에 overflow-wrap: anywhere를 추가했습니다. testProcessDir가 해당 CSS를 정규식으로 검증합니다.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

Suggested reviewers: copilot

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 좁은 뷰포트에서 긴 디렉터리 제목을 줄바꿈하는 주요 변경 사항을 정확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/long-heading-wrap-current

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 08:51
@seonghobae
seonghobae merged commit 26c5194 into master Aug 11, 2026
28 checks passed
@seonghobae
seonghobae deleted the fix/long-heading-wrap-current branch August 11, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant