Skip to content

docs: record fail-closed newsdom boundary - #78

Merged
seonghobae merged 1 commit into
mainfrom
codex/adr-newsdom-auth-boundary
Aug 11, 2026
Merged

docs: record fail-closed newsdom boundary#78
seonghobae merged 1 commit into
mainfrom
codex/adr-newsdom-auth-boundary

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • record the NewsDOM PR #595 fail-closed bearer boundary in ADR-0008
  • keep the sidecar explicitly deployment-restricted because it has no user-level ABAC/RBAC
  • add traceability for the anonymous-access boundary

Validation

  • uv run pytest ../../tests/test_documentation_contract.py -q
  • uv run ruff check app tests tools
  • uv run interrogate .
  • uv run python -m compileall -q app tests tools

No administrator merge or self-approval.

Summary by CodeRabbit

  • 문서
    • 추적성 매트릭스에 사이드카 익명 접근 경계 요구사항을 추가했습니다.
    • 서비스 경계와 최소 권한 정책에 따른 보안 기준 및 현재 검증 상태를 명확히 기록했습니다.
    • 인증되지 않은 요청은 기본적으로 차단되며, 익명 접근은 명시적으로 허용한 경우에만 사용할 수 있도록 관련 안내를 갱신했습니다.
    • 외부 노출 환경에서는 인증 게이트웨이 또는 검증된 서비스 경계를 사용하도록 권고합니다.

@seonghobae

Copy link
Copy Markdown
Contributor Author

@opencode-agent review

Please review exact current head 49433a6. This synchronizes ADR-0008 and TRACEABILITY with NewsDOM PR #595; no downstream app is claimed authorization-ready.

@seonghobae
seonghobae enabled auto-merge (squash) August 11, 2026 12:24
@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1b6c749d-6585-42c6-a329-925f76fb43d6

📥 Commits

Reviewing files that changed from the base of the PR and between 9b06ed2 and 49433a6.

📒 Files selected for processing (2)
  • docs/TRACEABILITY.md
  • docs/adr/0008-keyverse-rp-authorization-boundary.md

📝 Walkthrough

Walkthrough

추적성 매트릭스에 사이드카 익명 접근 경계를 추가했습니다. ADR-0008은 newsdom-api의 PR 기준 커밋과 fail-closed bearer 경계, 명시적 익명 파싱 허용 조건을 반영합니다.

Changes

권한 경계 문서 갱신

Layer / File(s) Summary
권한 경계 증거 및 정책 갱신
docs/TRACEABILITY.md, docs/adr/0008-keyverse-rp-authorization-boundary.md
newsdom-api 감사 기준을 PR #595 커밋으로 변경했습니다. 기본 fail-closed bearer 경계와 NEWSDOM_ALLOW_ANONYMOUS=true를 통한 명시적 익명 파싱 허용을 기록했습니다. 사이드카 익명 접근 경계의 현재 증거와 미충족 증거를 accepted-contract 상태로 추가했습니다.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • ContextualWisdomLab/keyverse#75: 동일한 추적성 매트릭스와 ADR-0008의 RP 권한 부여 및 익명 접근 경계 증거를 갱신한 PR입니다.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed 제목은 ADR-0008과 TRACEABILITY에 NewsDOM의 fail-closed 경계를 기록하는 주요 변경을 명확하고 간결하게 설명합니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/adr-newsdom-auth-boundary

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae merged commit 571df2a into main Aug 11, 2026
31 checks passed
@seonghobae
seonghobae deleted the codex/adr-newsdom-auth-boundary branch August 11, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant