Skip to content

fix(etl): bind durable job failure metadata to lifecycle - #271

Merged
github-actions[bot] merged 4 commits into
developfrom
fix/job-failure-metadata-invariant-942d164
Aug 11, 2026
Merged

fix(etl): bind durable job failure metadata to lifecycle#271
github-actions[bot] merged 4 commits into
developfrom
fix/job-failure-metadata-invariant-942d164

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Fixes #270.

Strict fail-first work from exact protected develop@942d164ceb7af497bb28a95f842db96429d1bdc4.

Exact current test-only head 7adfa643f9edef0c48b98fa54dcd030e492517f6 changes only EtlJobModelTest. The new production-boundary contract requires non-FAILED durable-job snapshots/status responses to reject non-null failure codes and FAILED representations to require a non-blank stable failure code. Protected source currently validates only required fields and non-negative attempts, so hosted RED must come from those four lifecycle/metadata assertions after normal compile/startup; setup/import/fixture/dependency failure is not valid RED.

Keep Draft through hosted RED. After valid RED, the narrow GREEN may touch only EtlJobSnapshot / EtlJobStatusResponse plus this focused test unless fresh evidence requires less. Preserve existing valid lifecycle representations, status vocabulary, opaque UUIDs, timestamps, attempt-count behavior, database schema, worker/lease behavior, active stack root #121, canonical docs #149, and shared POM/workflow gates. No predecessor or synthetic evidence is merge authority.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 2026ee03-8ab5-4b7d-a91a-cd0e07379756

📥 Commits

Reviewing files that changed from the base of the PR and between 942d164 and c051e52.

📒 Files selected for processing (3)
  • etl-service/src/main/java/com/xtrmetl/etl/job/EtlJobSnapshot.java
  • etl-service/src/main/java/com/xtrmetl/etl/job/EtlJobStatusResponse.java
  • etl-service/src/test/java/com/xtrmetl/etl/job/EtlJobModelTest.java

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@seonghobae
seonghobae marked this pull request as ready for review August 11, 2026 11:22
@github-actions
github-actions Bot merged commit 5866762 into develop Aug 11, 2026
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(etl): fail closed on inconsistent durable-job failure metadata

1 participant