fix(api): separate readiness method errors from readiness state - #102
fix(api): separate readiness method errors from readiness state#102seonghobae wants to merge 3 commits into
Conversation
|
Warning Review limit reached
Next review available in: 3 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Keep
/readymethod-validation failures distinct from actual runtime-readiness decisions. An unsupported method is a caller contract error, not evidence that Noema isnot-ready, and it should not instruct clients to retry after 30 seconds.Exact source identity
mainatc85d710804139c0697d7ef8fa47d02b1389e6d84;fix/readiness-method-semantics-on-main;6aa59985a0ad42c79f2aca7c44b435231df29a42;59fc75e41299548cb9cbce58cf487b39a397ba52;99db0fb0bbf65ce1bd497e57e41bc0a7708ee4c9;main.Test-first proof
The regression requires
POST,PUT,PATCH,DELETE, andOPTIONS /readyto preserve405,Allow: GET, HEAD, andERR_VALIDATION_INPUTwhile omittingX-Noema-ReadinessandRetry-After. Common non-cacheable diagnostic and trace headers remain asserted.On exact RED head
6aa59985a0ad42c79f2aca7c44b435231df29a42, applicationcirun31399939786completed with failure, whilereviewer-ci31399940052and centralSecurity Scan31399940108completed successfully. The narrow GREEN change makes the readiness header helper's state optional: only real readiness decisions setX-Noema-Readiness, and only a realnot-readydecision setsRetry-After.Current head
99db0fb0bbf65ce1bd497e57e41bc0a7708ee4c9hardens the executable 405 contract further: every unsupported method now pinscontent-type: application/json; charset=utf-8and verifies that the JSONtrace_idexactly matchesX-Trace-Id, in addition to the existing Allow/cache/Pragma/nosniff/latency/error assertions. This is test-only hardening; runtime semantics are unchanged from the first GREEN.Current exact-head evidence
For unchanged head
99db0fb0bbf65ce1bd497e57e41bc0a7708ee4c9:cirun31418474817: terminal success;reviewer-cirun31418474949: terminal success;Security Scanrun31418474812: terminal success under current protected-base scanner semantics;main.Behavioral boundary
200,X-Noema-Readiness: ready;503,X-Noema-Readiness: not-ready,Retry-After: 30;405,Allow: GET, HEAD, no readiness-state claim, no retry advice, and the common JSON/trace/cache/security response contract remains pinned.Credential exchange behavior, dependencies, workflows, licensing, release, deployment, governance, and reviewer authority are unchanged.
Merge / operational boundary
Technical success is not merge authority. Live enforceable governance under #27 and an eligible qualifying independent non-author formal-review path under #29 remain separate fail-closed gates where required. No self-approval, protection weakening, synthetic status, release, deployment, licensing, or acquisition-readiness claim is made.