Skip to content

fix(api): separate readiness method errors from readiness state - #102

Open
seonghobae wants to merge 3 commits into
mainfrom
fix/readiness-method-semantics-on-main
Open

fix(api): separate readiness method errors from readiness state#102
seonghobae wants to merge 3 commits into
mainfrom
fix/readiness-method-semantics-on-main

Conversation

@seonghobae

@seonghobae seonghobae commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Purpose

Keep /ready method-validation failures distinct from actual runtime-readiness decisions. An unsupported method is a caller contract error, not evidence that Noema is not-ready, and it should not instruct clients to retry after 30 seconds.

Exact source identity

  • protected base: main at c85d710804139c0697d7ef8fa47d02b1389e6d84;
  • head branch: fix/readiness-method-semantics-on-main;
  • RED head: 6aa59985a0ad42c79f2aca7c44b435231df29a42;
  • first GREEN runtime head: 59fc75e41299548cb9cbce58cf487b39a397ba52;
  • current exact head after protocol-contract hardening: 99db0fb0bbf65ce1bd497e57e41bc0a7708ee4c9;
  • direct-main merge base remains current protected main.

Test-first proof

The regression requires POST, PUT, PATCH, DELETE, and OPTIONS /ready to preserve 405, Allow: GET, HEAD, and ERR_VALIDATION_INPUT while omitting X-Noema-Readiness and Retry-After. Common non-cacheable diagnostic and trace headers remain asserted.

On exact RED head 6aa59985a0ad42c79f2aca7c44b435231df29a42, application ci run 31399939786 completed with failure, while reviewer-ci 31399940052 and central Security Scan 31399940108 completed successfully. The narrow GREEN change makes the readiness header helper's state optional: only real readiness decisions set X-Noema-Readiness, and only a real not-ready decision sets Retry-After.

Current head 99db0fb0bbf65ce1bd497e57e41bc0a7708ee4c9 hardens the executable 405 contract further: every unsupported method now pins content-type: application/json; charset=utf-8 and verifies that the JSON trace_id exactly matches X-Trace-Id, in addition to the existing Allow/cache/Pragma/nosniff/latency/error assertions. This is test-only hardening; runtime semantics are unchanged from the first GREEN.

Current exact-head evidence

For unchanged head 99db0fb0bbf65ce1bd497e57e41bc0a7708ee4c9:

  • application ci run 31418474817: terminal success;
  • reviewer-ci run 31418474949: terminal success;
  • central Security Scan run 31418474812: terminal success under current protected-base scanner semantics;
  • current inline review threads: 0 at the latest fresh read;
  • current formal GitHub reviews: 0;
  • GitHub reports the PR mergeable and the branch 3 commits ahead / 0 behind protected main.

Behavioral boundary

  • actual ready response: unchanged 200, X-Noema-Readiness: ready;
  • actual not-ready response: unchanged 503, X-Noema-Readiness: not-ready, Retry-After: 30;
  • unsupported method: 405, Allow: GET, HEAD, no readiness-state claim, no retry advice, and the common JSON/trace/cache/security response contract remains pinned.

Credential exchange behavior, dependencies, workflows, licensing, release, deployment, governance, and reviewer authority are unchanged.

Merge / operational boundary

Technical success is not merge authority. Live enforceable governance under #27 and an eligible qualifying independent non-author formal-review path under #29 remain separate fail-closed gates where required. No self-approval, protection weakening, synthetic status, release, deployment, licensing, or acquisition-readiness claim is made.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 3 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 272ba7be-11b1-4ca0-86b2-6a59faca4b6f

📥 Commits

Reviewing files that changed from the base of the PR and between c85d710 and 99db0fb.

📒 Files selected for processing (2)
  • src/runtime-entrypoint.ts
  • test/readiness-method-contract.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@seonghobae
seonghobae marked this pull request as ready for review August 10, 2026 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant