fix(security): redact main-governance child token diagnostics - #137
fix(security): redact main-governance child token diagnostics#137seonghobae wants to merge 2 commits into
Conversation
|
Warning Review limit reached
Next review available in: 44 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Purpose
Test-first repair for #136. The main-governance audit already narrows GitHub CLI child authority, but a failing child could echo the delegated
GH_TOKENinto retained failure diagnostics. This line removes the exact delegated token before diagnostics are bounded or persisted.Exact current identity
mainc85d710804139c0697d7ef8fa47d02b1389e6d84;fix/main-governance-diagnostic-redaction;59dd374799efe83c592ab23aab9acd18dd4e0c3f;f4d7f6471f00de55a8e3354750b5703460e2c780;main, merge base exactly the live protected head;scripts/main-governance-audit.mjs,test/main-governance-audit-script.test.ts.RCA -> RED -> GREEN
The first failing boundary was GitHub CLI failure output -> retained governance diagnostics.
runGh()bounded child startup/non-zero text but did not remove the short-lived delegated token first. The narrow repair now constructs the GitHub CLI child environment explicitly, pinsGH_HOST=github.comandNO_COLOR=1, retains only optional non-emptyPATHplus explicitGH_TOKEN, and redacts the exact delegated token from startup and non-zero diagnostics beforebound()can feed report/summary/stdout evidence.The hostile-parent regression proves ambient
GITHUB_TOKEN, model/provider/App private material, Cloudflare credentials, proxies,HOME,NODE_OPTIONS, and unrelated state do not cross the child boundary. Existing API version, pagination, timeout/max-buffer, shell-free execution and fail-closed governance evaluation remain unchanged.Exact current-head proof
For unchanged current head
f4d7f6471f00de55a8e3354750b5703460e2c780:ci31451862463: terminal success;reviewer-ci31451862443: terminal success;Security Scan31451862447: terminal success;COMMENTEDsubmission fromgithub-code-quality, no qualifyingAPPROVEDreview;A CodeRabbit review request was rate-limited on this exact base/head. That is transient model/review evidence and is not promoted to approval or a passing gate.
Authority boundary
This repair hardens child-process authority and retained diagnostics only. It does not prove the live
mainruleset, create an eligible independent reviewer, modify workflow permissions, publish a release, deploy Noema, choose an outbound license, establish production KPI/revenue/transfer evidence, or make an acquisition-readiness claim. Technical GREEN is not merge authority; #27/#29 retain the live governance and qualifying independent-review boundary.Related: #27, #29, #90, #106, #136