Skip to content

fix(api): restack unsupported exchange method short-circuit on current main - #206

Closed
seonghobae wants to merge 5 commits into
mainfrom
fix/exchange-method-contract-current-main-v2
Closed

fix(api): restack unsupported exchange method short-circuit on current main#206
seonghobae wants to merge 5 commits into
mainfrom
fix/exchange-method-contract-current-main-v2

Conversation

@seonghobae

Copy link
Copy Markdown
Contributor

Fresh protected-main successor for #101 on exact base 1a8a77d67f61a2c61e88974be9206a91d19acdf4. No predecessor checks, reviews, scanner output, model judgment, or production evidence transfers.

Current test-first RED head 74ee8801620e5189ee3ac0c8ededd049c638365d adds only the executable /exchange method contract. Current protected src/entrypoint.ts enters OIDC envelope/body and GitHub egress-configuration handling before rejecting unsupported methods; the regression requires GET/HEAD/PUT/PATCH/DELETE/OPTIONS to return the public 405 contract before credential egress configuration and distributed limiter side effects, with HEAD bodyless.

Selected bounded GREEN after RED is proven: short-circuit unsupported methods at the outer /exchange entrypoint while preserving POST behavior, security/cache/trace headers, and every credential-bearing path.

Historical #101 remains open until this current-main successor proves and preserves the complete two-file contract.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e613bb5-d916-4634-ba2c-e74d153c46b5

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Contributor Author

Superseded by fresh protected-main successor #214 after exact byte/scope comparison.

Fresh identities immediately before this closure decision:

Preservation proof:

Closing #206 unmerged removes the stale parallel writer without discarding unique API behavior or tests. #214 remains the sole current-main owner; its branch is otherwise left untouched in this invocation because its head moved during the fresh writer-state sweep.

@seonghobae seonghobae closed this Aug 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant