Skip to content

⚡ Bolt: [Async PBKDF2 hashing] - #822

Open
seonghobae wants to merge 1 commit into
mainfrom
perf-async-hash-14919484376266355480
Open

⚡ Bolt: [Async PBKDF2 hashing]#822
seonghobae wants to merge 1 commit into
mainfrom
perf-async-hash-14919484376266355480

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

💡 What:
hash_api_key 함수 내부의 동기적 PBKDF2 해싱을 asyncio.to_thread를 통해 별도의 스레드 풀로 오프로드하고, 함수를 async def로 변경하여 모든 호출부에서 await하도록 수정했습니다.

🎯 Why:
PBKDF2-HMAC-SHA256 해싱은 21만 번의 반복을 수행하는 CPU 집약적인 작업으로, 동기적으로 실행될 경우 약 180~200ms 동안 비동기 이벤트 루프 전체를 멈추게 합니다. 인증과 같은 자주 호출되는 핫 패스에서 이러한 루프 차단이 발생하면 다른 요청의 처리가 모두 지연되므로, 이를 비동기화하여 전체 애플리케이션의 응답성과 처리량을 확보하기 위함입니다.

📊 Measured Improvement:
로컬 벤치마크 결과, 0.01초 단위로 측정하는 이벤트 루프 티커(ticker) 기준으로:

  • 최적화 전: 해싱 도중 이벤트 루프가 완전히 차단되어(약 0.18s) 티커가 0번 실행됨.
  • 최적화 후: 해싱이 스레드 풀로 오프로드되어(약 0.18s) 이벤트 루프가 정상 동작하며 티커가 약 17번 실행됨.
    이를 통해 무거운 연산 중에도 이벤트 루프가 정상적으로 동작함을 확인했습니다.

PR created automatically by Jules for task 14919484376266355480 started by @seonghobae

@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 27 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4f5a3e78-6151-483c-a8bb-77f8f74219a2

📥 Commits

Reviewing files that changed from the base of the PR and between 72afe6d and 89c65eb.

📒 Files selected for processing (6)
  • .jules/bolt.md
  • backend/app/api/api_keys.py
  • backend/app/auth.py
  • backend/tests/test_api_keys.py
  • backend/tests/test_auth_security.py
  • backend/tests/test_csrf_middleware.py

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant