Skip to content

fix(a11y): use native form submission paths - #835

Open
seonghobae wants to merge 1 commit into
mainfrom
codex/native-form-submit-v2
Open

fix(a11y): use native form submission paths#835
seonghobae wants to merge 1 commit into
mainfrom
codex/native-form-submit-v2

Conversation

@seonghobae

Copy link
Copy Markdown
Collaborator

Outcome

Keyboard and assistive-technology users can submit project and connection creation from focused inputs with Enter through the same guarded path used by button activation. Diagram and canvas search controls are semantic search forms that prevent navigation while preserving live filtering.

Changes

  • wrap editor/project-list creation and connection creation in native forms
  • use one submit handler per creation action; remove duplicate click dispatch
  • preserve whitespace, DSN, secret-clearing, and in-flight request guards
  • expose diagram and canvas searches as role="search" forms
  • stabilize the async graph-refresh coverage test before enabling fake timers
  • document behavior, recovery, standards references, and changelog entry

Test-first evidence

The focused regression initially failed because Enter did not call createProject. After implementation:

  • App.coverage.test.tsx: 21 passed
  • full frontend suite: 27 files, 201 tests passed
  • typecheck: passed
  • production build: passed
  • coverage run: 27 files, 201 tests passed; App branches 100%
  • git diff --check: passed

The repository-wide coverage report remains at its existing aggregate baseline (99.8% statements / 99.55% branches); this change introduces no uncovered App branch.

Closes #756

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@seonghobae, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 1 minute

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 167efded-ad5f-488e-aa63-5c524c4733cf

📥 Commits

Reviewing files that changed from the base of the PR and between 72afe6d and 3d7d948.

📒 Files selected for processing (4)
  • CHANGELOG.md
  • docs/doctoring/native-form-submission.md
  • frontend/src/App.coverage.test.tsx
  • frontend/src/App.tsx

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

Please perform a fresh independent review of unchanged exact head 3d7d94857f6ba64a73965373b04a6769c55c34a0. All current CI/security workflows are green and no unresolved inline thread is recorded; merge remains deferred until exact-head review evidence is available.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

@seonghobae I will perform a fresh independent review of PR #835 at exact head 3d7d94857f6ba64a73965373b04a6769c55c34a0. I will assess the change independently, including the native form submission paths and accessibility behavior described in the PR objectives.

⚠️ Action not completed

Review rate limited.


Your included review limit is currently reached under our Fair Usage Limits Policy. This review may still proceed through usage-based billing if eligible. Your next included review will be available in 48 minutes.

Copy link
Copy Markdown
Collaborator Author

@coderabbitai review

Please review exact head 3d7d94857f6ba64a73965373b04a6769c55c34a0. Required ci, Security Scan, and SAST Semgrep workflows are successful and there are no unresolved review threads; no formal review currently exists.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown

@seonghobae I will review PR #835 at exact head 3d7d94857f6ba64a73965373b04a6769c55c34a0.

⚠️ Action not completed

Review rate limited.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Accessibility] Rebuild native Enter-key submission as a bounded App change

1 participant