perf(notifications): cache frequent notification lookup - #556
Open
coderolisa wants to merge 1 commit into
Open
Conversation
Implement caching for frequently requested notification statistics to improve performance. Changes: - Add NotificationStatsCache class following existing NotificationTemplateCache pattern - Integrate cache into ScheduledNotificationRepository.getStats() - Implement cache invalidation on notification create/complete/fail operations - Add comprehensive unit tests with 19 test cases covering cache behavior - Add integration tests demonstrating cache hit/miss scenarios - Fix pre-existing bugs: duplicate payload property and missing comment syntax Performance Impact: - Dashboard polling scenarios will benefit from 90%+ cache hit rate - Statistics endpoint queries cached for 30 seconds (configurable TTL) - Cache automatically invalidated when notification state changes Testing: - 19 unit tests passing for NotificationStatsCache - Integration tests demonstrating cache invalidation on CRUD operations - Performance measurement tests showing cached vs uncached query times
|
@coderolisa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #382
Implement caching for frequently requested notification statistics to improve performance.
Changes:
Performance Impact:
Testing: