test(subscriptions): add duplicate subscription regression test - #558
Open
coderolisa wants to merge 1 commit into
Open
test(subscriptions): add duplicate subscription regression test#558coderolisa wants to merge 1 commit into
coderolisa wants to merge 1 commit into
Conversation
Introduce SubscriptionService with duplicate detection to prevent users from subscribing multiple times to the same notification channel. Changes: - Add subscription types with typed error codes - Implement SubscriptionService with fingerprint-based duplicate detection - Add 17 unit tests covering duplicate prevention, input validation, subscription lifecycle, and edge cases Core duplicate prevention logic: - Uses userId:channel fingerprint for uniqueness - Returns existing subscription with DUPLICATE_SUBSCRIPTION error - Preserves original subscription data unchanged - Allows re-subscription after explicit unsubscribe All new tests pass. Existing behavior unchanged. Contributes toward notification channel subscription management.
|
@coderolisa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #373
ntroduce SubscriptionService with duplicate detection to prevent users from subscribing multiple times to the same notification channel.
Changes:
Core duplicate prevention logic:
All new tests pass. Existing behavior unchanged.
Contributes toward notification channel subscription management.