Skip to content

Demo Preparation: Item & General Second Demo Preparations - #254

Open
Setnour6 wants to merge 15 commits into
masterfrom
DemoPrep0a
Open

Demo Preparation: Item & General Second Demo Preparations#254
Setnour6 wants to merge 15 commits into
masterfrom
DemoPrep0a

Conversation

@Setnour6

@Setnour6 Setnour6 commented Mar 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Improved PR of #226.

The second set of changes for the second demo release of Everglow, aimed for 1.4.4. The first set of changes was #247.

How to test

  1. Create a new world
  2. See if the demo chest generations are good and if the code changes made to the demo chest generation is good. There should be two chests with both Spell book content and bayonet content.
  3. Test all items and NPCs listed in the "Files changed" tab on this Pull Request. Other items to test that aren't listed are the Silveral weapons (internal names are SilveralRifle and SilveralGun). Make sure to use an inventory-editing or item-giving mod like HERO's Mod, Cheat Sheet, DragonLens, etc. and make sure the WMITF mod is enabled so it is easier for you to see the internal item names.
  4. (Optional) Test localization changes with Setnour6/EverglowLocalization.

Setnour6 and others added 10 commits March 2, 2024 10:26
@Setnour6
Setnour6 requested a review from Felixyang777 April 11, 2024 17:40
@Setnour6 Setnour6 added enhancement New feature or request priority: high This should be considered or being worked on soon priority type: pre-release This should be considered or worked on before release [Temporary Label] labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CXUtk CXUtk Awaiting requested review from CXUtk
@Solaestas Solaestas Awaiting requested review from Solaestas
@Omnielement Omnielement Awaiting requested review from Omnielement
@lace-wing lace-wing Awaiting requested review from lace-wing
@Felixyang777 Felixyang777 Awaiting requested review from Felixyang777
@Cyrillya Cyrillya Awaiting requested review from Cyrillya
@zqzcsilver zqzcsilver Awaiting requested review from zqzcsilver
@LingASDJ LingASDJ Awaiting requested review from LingASDJ
@shb201902040125 shb201902040125 Awaiting requested review from shb201902040125
@AWEoghAwo AWEoghAwo Awaiting requested review from AWEoghAwo
@slime1024 slime1024 Awaiting requested review from slime1024
@doggoowo doggoowo Awaiting requested review from doggoowo

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request priority: high This should be considered or being worked on soon priority type: pre-release This should be considered or worked on before release [Temporary Label]

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Setnour6 @Omnielement