Improve selected state and keyboard navigation in DSO selector#5876
Open
hernanhlagos wants to merge 1 commit into
Open
Improve selected state and keyboard navigation in DSO selector#5876hernanhlagos wants to merge 1 commit into
hernanhlagos wants to merge 1 commit into
Conversation
309902a to
f44c56d
Compare
|
Thank you for putting up this pull request @hernanhlagos! You may have already seen, but this is currently failing a few build tests that will need to be fixed - looks like just minor linting errors though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR fixes the visual state of the selected collection in the selector, when moving an item from one collection to another, and also fixes keyboard navigation in Safari.
Instructions for Reviewers
List of changes in this PR:
listEntry.indexableObject.idinstead of usinglistEntry['id'].activestate, so the selected collection is clearly marked.tabindex="0"to the list entries to fix a Safari issue where focus skipped the collection list and moved directly from the search input to the final action buttons.@for$indexto support keyboard navigation withArrowDownandArrowUpbetween collection entries in Safari.How to test:
Tabfrom the search input and verify that focus enters the collection list instead of skipping to the final action buttons.ArrowDownandArrowUpto move through the collection entries.EnterorSpaceto select the focused collection.Note: I was not able to reproduce the keyboard navigation issue in Chrome, but I was able to reproduce and validate the fix in Safari.
Checklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the [DSpace BSD License](https://github.com/DSpace/DSpace/blob/main/LICENSE) based on the [Licensing of Contributions](https://wiki.lyrasis.org/display/DSPACE/Code+Contribution+Guidelines#CodeContributionGuidelines-LicensingofContributions) documentation.