Fix ORCID redirect URI double slash#5884
Open
hernanhlagos wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Description
This PR fixes the ORCID authorization URL generation to avoid adding an extra slash before the entity route in the
redirect_uriparameter.Instructions for Reviewers
This PR keeps the fix intentionally small and limited to the ORCID authorization URL generation.
List of changes in this PR:
OrcidAuthService#getOrcidAuthorizeUrl()to pass the raw Angular router path toURLCombiner, instead of encoding the route before combining it with the application origin.redirect_uridoes not contain an encoded leading slash before the/entities/...route.How to test or review this PR:
/entities/person/{uuid}/orcidredirect_uriwith a single slash after the domain before/entities/....Expected result:
redirect_uri=https://demo.dspace.org/entities/person/{uuid}/orcidInstead of:
redirect_uri=https://demo.dspace.org/%2Fentities/person/{uuid}/orcidThe updated spec can be run with:
npm testChecklist
mainbranch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lintnpm run check-circ-deps)package.json), I've made sure their licenses align with the [DSpace BSD License](https://github.com/DSpace/DSpace/blob/main/LICENSE) based on the [Licensing of Contributions](https://wiki.lyrasis.org/display/DSPACE/Code+Contribution+Guidelines#CodeContributionGuidelines-LicensingofContributions) documentation.