Use install directory instead of in-source build for Breakpad#32
Open
slipher wants to merge 4 commits into
Open
Use install directory instead of in-source build for Breakpad#32slipher wants to merge 4 commits into
slipher wants to merge 4 commits into
Conversation
To activate Breakpad tests in Scons, you should now pass breakpad_install_dir=<Breakpad install prefix> instead of breakpad_tools_dir=<Breakpad repository root with in-source build>.
It will be automatically used if found there. The scons 'Dir' object had to be dropped in favor of plain strings for the related paths since it goes crazy if the path is inside the source tree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also fix some minor Breakpad-related Scons build issues.