feat: allow-under-default-allow smell — ufw's decorative whitelist (v1.27.0) - #41
Merged
Merged
Conversation
…1.27.0) Under 'Default: allow (incoming)' every ufw ALLOW rule with no DENY below it restricts nothing: the status output reads like a whitelist while being decorative. Composes with missing-input-drop on the other axis (policy vs rules). Allows above a deny are spared (they punch holes — a different problem); LIMIT keeps its throttle either way. New sample 'ufw (default allow — decorative rules)'. 36 smells, tests 155 -> 161. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
New linter smell
allow-under-default-allow(warning, ufw-only) — the silent-no-op family: ufw's whole UX isufw allow <port>, but underDefault: allow (incoming)every packet is accepted before the rule list matters. The allows are decorative:ufw statusreads like a whitelist while restricting nothing — the admin believes unlisted ports are blocked.Two axes, two findings
missing-input-dropalready reports the open door (error, the policy axis). This reports the lie in the list (warning, the rules axis). Both fire together on the new sample — pinned by test. Same split asexposed-admin-port(who reaches it) vsadmin-port-no-rate-limit(how fast).What keeps it honest
Wiring
ufw (default allow — decorative rules): a working DENY up top, three decorative allows, a LIMIT — trips exactly one finding with three no-ops, anchored past the deny.🤖 Generated with Claude Code