Write helpers into module bytecode directly - #12134
Closed
sarahchen6 wants to merge 3 commits into
Closed
Conversation
This comment has been minimized.
This comment has been minimized.
Contributor
🟢 Java Benchmark SLOs — All performance SLOs passed
PR vs. master results
Commit: Load and DaCapo benchmarks can be triggered manually in the GitLab pipeline. Results will appear in the Benchmarking Platform UI after completion. |
Contributor
|
It looks way better in terms of startup. As discussed a possible improvement is to write it deparately from the muzzle plugin still reusing part of its logic for the class dependency find |
sarahchen6
force-pushed
the
sarahchen6/infer-helper-classes-pt-1
branch
from
August 11, 2026 16:52
29b0bff to
a8cdba9
Compare
sarahchen6
force-pushed
the
sarahchen6/use-array
branch
from
August 11, 2026 17:15
3dc6d89 to
f147e6b
Compare
Contributor
Author
|
These changes make more sense directly a part of #12059 - I've cherry-picked the commits here onto that PR and will now close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Write the build-time-resolved helper list directly into each module's
helperClassNames()bytecode. The transformer will now read helper class names directly instead of needing to load the$Muzzleclass.Motivation
Without this change, the
$Muzzleside class is loaded eagerly to get the helper class names, negatively affecting startup time. Instead we can write the helpers directly into the bytecode and avoid loading the muzzle class.Additional Notes
This is built off of #12059 and offers an alternative to #12116 in addressing the startup time issues. The changes here are more minimal, but we are rewriting the module bytecode in place.
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]