perf(feature-flagging): bound UFC response memory - #12214
Draft
leoromanovsky wants to merge 1 commit into
Draft
Conversation
|
🎯 Code Coverage (details) 🔗 Commit SHA: 8f7fdd2 | Docs | Datadog PR Page | Give us feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The client accepted UFC responses without a size limit. A 12 MiB identity response allocated 25,281,544 bytes. A 20 MiB gzip expansion allocated 42,374,176 bytes from 20,405 compressed bytes. A large response could exhaust the application heap.
Changes and Decisions
Validation
The same allocation probe rejected the 12 MiB identity response after 1,769,896 allocated bytes. It rejected the gzip expansion at 10 MiB after 10,607,168 allocated bytes.