fix(ffe): isolate malformed flag configurations - #4103
Draft
leoromanovsky wants to merge 1 commit into
Draft
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
A malformed flag in a UFC payload must not prevent neighboring valid flags from being evaluated. Rejected flags must return the caller default with
ERROR/PARSE_ERROR, while missing flags remainFLAG_NOT_FOUND.Changes
ffe-system-test-datato the merged PR CircleCI integration doesn't work #26 corpus.d20319f8a108b9ee738af41e7f49f1875ce3c245), which owns malformed-flag isolation and evaluation semantics.Decisions
Validation
cargo check -p datadog-phpmake test_c TESTS=tests/ext/ffe/system_test_data_evaluate.phpt MAX_TEST_PARALLELISM=1git diff --check