Skip to content

fix(ffe): isolate malformed flag configurations - #4103

Draft
leoromanovsky wants to merge 1 commit into
masterfrom
agent/isolate-malformed-flags
Draft

fix(ffe): isolate malformed flag configurations#4103
leoromanovsky wants to merge 1 commit into
masterfrom
agent/isolate-malformed-flags

Conversation

@leoromanovsky

Copy link
Copy Markdown
Contributor

Motivation

A malformed flag in a UFC payload must not prevent neighboring valid flags from being evaluated. Rejected flags must return the caller default with ERROR / PARSE_ERROR, while missing flags remain FLAG_NOT_FOUND.

Changes

Decisions

  • Keep malformed flag parsing and SemVer behavior in libdatadog; PHP remains a narrow bridge.
  • Treat rejected and absent flags as distinct contract states.
  • Exercise the contract through the production PHP extension instead of duplicating fixture logic.

Validation

  • cargo check -p datadog-php
  • make test_c TESTS=tests/ext/ffe/system_test_data_evaluate.phpt MAX_TEST_PARALLELISM=1
  • git diff --check

@datadog-prod-us1-6

datadog-prod-us1-6 Bot commented Aug 11, 2026

Copy link
Copy Markdown

Pipelines  Tests

Unblock PR with BitsAI

⚠️ Warnings

🚦 78 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | ASAN test_c: [8.0, arm64]   View in Datadog   GitLab

🧪 6 Tests failed

All test failures are known flaky.

❄️ Known flaky: tmp/build_extension/tests/ext/telemetry/composer.phpt (Read telemetry via composer) from PHP.tmp.build_extension.tests.ext.telemetry   View in Datadog
--
                 [0] => Array
                     (
                         [name] => datadog/dd-trace
010+                     [hash] => 
011+                     [metadata] => 
                     )
     
                 [1] => Array
                     (
...

Not introduced in this PR.

❄️ Known flaky: tmp/build_extension/tests/ext/telemetry/integration.phpt (Signal integration telemetry) from PHP.tmp.build_extension.tests.ext.telemetry   View in Datadog
--
       ["integrations"]=>
       array(1) {
         [0]=>
007+     array(6) {
007-     array(5) {
           ["name"]=>
           string(37) "ddtrace\test\testsandboxedintegration"
           ["enabled"]=>
--
...

Not introduced in this PR.

View all failed tests

DataDog/apm-reliability/dd-trace-php | ASAN test_c: [8.5, arm64]   View in Datadog   GitLab

🧪 6 Tests failed

All test failures are known flaky.

❄️ Known flaky: tmp/build_extension/tests/ext/telemetry/composer.phpt (Read telemetry via composer) from php.tmp.build_extension.tests.ext.telemetry   View in Datadog
--
                     (
                         [name] => datadog/dd-trace
                         [version] => dev-master
010+                     [hash] => 
011+                     [metadata] => 
                     )
     
                 [1] => Array
                     (
...

Not introduced in this PR.

❄️ Known flaky: tmp/build_extension/tests/ext/telemetry/integration.phpt (Signal integration telemetry) from php.tmp.build_extension.tests.ext.telemetry   View in Datadog
--
       ["integrations"]=>
       array(1) {
         [0]=>
007-     array(5) {
007+     array(6) {
           ["name"]=>
           string(37) "ddtrace\test\testsandboxedintegration"
           ["enabled"]=>
--
...

Not introduced in this PR.

View all failed tests

DataDog/apm-reliability/dd-trace-php | test_web_custom: [8.0, fpm-fcgi]   View in Datadog   GitLab

🧪 1 Test failed

All test failures are known flaky.

❄️ Known flaky: testInstrumentation from custom-framework-autoloading-test.DDTrace\Tests\Integrations\Custom\Autoloaded\InstrumentationTest   View in Datadog
DDTrace\Tests\Integrations\Custom\Autoloaded\InstrumentationTest::testInstrumentation
Failed asserting that an array has the key 'logs_created'.

tests/Integrations/Custom/Autoloaded/InstrumentationTest.php:80
tests/Common/RetryTraitVersionGeneric.php:28

Not introduced in this PR.

View all 78 failed jobs.

ℹ️ Info

No other issues found (see more)

❄️ No new flaky tests detected

🎯 Code Coverage (details)
Patch Coverage: 100.00%
Overall Coverage: 60.62% (-0.04%)

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: bb4012d | Docs | Datadog PR Page | Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant