build(deps): bump tests/FeatureFlags/ffe-system-test-data from 4446371 to ea8b5cc - #4107
Conversation
Bumps [tests/FeatureFlags/ffe-system-test-data](https://github.com/DataDog/ffe-system-test-data) from `4446371` to `ea8b5cc`. - [Commits](DataDog/ffe-system-test-data@4446371...ea8b5cc) --- updated-dependencies: - dependency-name: tests/FeatureFlags/ffe-system-test-data dependency-version: ea8b5cc5ce335109f11f3efbc5fd608f98a3ca54 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
added
dependencies
dependabot
Bot
added
dependencies
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bf5eecdbda
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit 4446371bc1ca52bd526356927ef42d380145b118 | |||
| Subproject commit ea8b5cc5ce335109f11f3efbc5fd608f98a3ca54 | |||
There was a problem hiding this comment.
This fixture bump adds expectations whose only observable contract is result.reason/result.errorCode (for example unknown flags are now ERROR/FLAG_NOT_FOUND, and several malformed flags expect PARSE_ERROR), but the PHP sweep still only compares result.value in tests/ext/ffe/system_test_data_evaluate.phpt:173. When those new cases run, PHP can return the right default value with the wrong reason or error code and the canonical fixture test will still pass, so this submodule update does not actually validate the behavior it is adding; please extend the harness to compare getReason() and getErrorCode() when present.
Useful? React with 👍 / 👎.
|
Bumps tests/FeatureFlags/ffe-system-test-data from
4446371toea8b5cc.Commits
ea8b5ccMerge pull request #26 from DataDog/agent/variant-type-mismatch-fixturescc2c56atest: clarify malformed flag errorsa2a7c39test: report rejected flags as parse errorsaa33162ci: surface downstream incompatibilities74ea557Merge malformed condition fixtures into variant type mismatch fixtures7241a04test: remove malformed flags during ingestion462240etest: remove malformed variant flags288392ftest: define malformed condition parse errors42328edtest: add variant type mismatch fixtures43e600bMerge pull request #19 from DataDog/leo.romanovsky/invalid-regex-isolationDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)