test(cpp): enable otel tracestate sampling [cpp@milan.garnier/otel-tracestate-ot-th] - #7522
Conversation
|
|
| tests/parametric/test_otel_span_with_baggage.py::Test_Otel_Span_With_Baggage: missing_feature | ||
| tests/parametric/test_otel_tracer.py::Test_Otel_Tracer::test_otel_force_flush: irrelevant (library does not implement OpenTelemetry) | ||
| tests/parametric/test_otel_tracer.py::Test_Otel_Tracer::test_otel_simple_trace: irrelevant (library does not implement OpenTelemetry) | ||
| tests/parametric/test_otel_tracestate_sampling.py::Test_OtelTracestateSampling: ">2.1.2" |
There was a problem hiding this comment.
This should rather be >=2.2.0 since dd-trace-cpp v2.2.0 was delivered 2 days ago.
See #7517.
There was a problem hiding this comment.
oh thanks I hadn't seen that yet !
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0378ec0860
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| tests/parametric/test_otel_tracestate_sampling.py::Test_OtelTracestateSampling: ">2.1.2" | ||
| tests/parametric/test_otel_tracestate_sampling.py::Test_OtlpTracestateSampling: ">2.1.2" |
There was a problem hiding this comment.
When running a future C++ 2.1.x patch release, these entries match any version greater than 2.1.2, so the new tracestate sampling tests would run before the feature's 2.2.0 boundary and fail in that maintenance line; the rest of this manifest already corrected the same >2.1.2 pattern to >=2.2.0, so these activations should use the real floor (for example v2.2.0/>=2.2.0) rather than a previous-version cutoff. .cursor/rules/pr-review.mdcL20-L22
Useful? React with 👍 / 👎.
|
8f5e665 to
7038c67
Compare
2 participants
Enables C++ OpenTelemetry tracestate sampling coverage. Stacked on #7518.