Add semantic-layer REST API exposing cubes as views#2318
Merged
Conversation
Expose /semantic/* so external clients can browse cubes as views and get physical SQL to execute. SQL generation reuses DJ's canonical metrics-SQL path via a shared generate_metrics_sql helper; dialect resolution is pin-aware so a pinned cube's dialect matches the cube it builds from.
✅ Deploy Preview for thriving-cassata-78ae72 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shangyian
approved these changes
Jul 8, 2026
shangyian
left a comment
shangyian
left a comment
Collaborator
There was a problem hiding this comment.
Generally LGTM! 🚢 Only left some minor comments
The cube_filters merge moved into the shared generate_metrics_sql helper, but the [SQL] log statement stayed in get_metrics_sql_v3. Move the timer/counter/log into generate_metrics_sql so the logged values are the as-built ones.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of the spec from https://github.com/betodealmeida/sl-db-engine-spec/blob/5f41b523975b2547ba73fb606a0b69615fc6967e/server/SPEC.md
Expose /semantic/* so external clients can browse cubes as views and get physical SQL to execute. SQL generation reuses DJ's canonical metrics-SQL path via a shared generate_metrics_sql helper; dialect resolution is now pin-aware so a pinned cube's dialect matches the cube it builds from.