Make sqlglot a required dependency#2324
Merged
robinld merged 1 commit intoJul 10, 2026
Merged
Conversation
✅ Deploy Preview for thriving-cassata-78ae72 canceled.
|
DJ transpiles generated SQL per dialect via sqlglot and has no realistic fallback, yet sqlglot was only an optional extra (`transpilation`, and duplicated in `bigquery`). Promote sqlglot to a core dependency and drop the now-redundant optional plumbing: - pyproject.toml: add `sqlglot>=18.0.1` to core dependencies; remove the `transpilation` extra and the duplicate entry in the `bigquery` extra. - transpilation.py: import sqlglot at module top level - Drop the now-invalid `--extra transpilation` from every `uv sync` invocation: Makefile, CI (test.yml), the server Dockerfile, and docker-compose. - requirements/docker.txt: update the documented export command - uv.lock: sqlglot moves from the extras to the core dependency set. - CONTRIBUTING.rst: refresh the stale "Adding new dependencies" and setup instructions (now uses uv).
robinld
force-pushed
the
robind/sqlglot-required-dependency
branch
from
2e88dbe to
3e30dd4
Compare
shangyian
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DJ transpiles generated SQL per dialect via sqlglot and has no realistic fallback, yet sqlglot was only an optional extra (
transpilation, and duplicated inbigquery).Promote sqlglot to a core dependency and drop the now-redundant optional plumbing:
sqlglot>=18.0.1to core dependencies; remove thetranspilationextra and the duplicate entry in thebigqueryextra.--extra transpilationfromuv sync.