fix: headless/non-interactive Rdx for bots (cast + empty output file) - #88
Open
crl33 wants to merge 1 commit into
Open
fix: headless/non-interactive Rdx for bots (cast + empty output file)#88crl33 wants to merge 1 commit into
crl33 wants to merge 1 commit into
Conversation
Non-interactive mode crashed after upload with InvalidCastException because GetFullRows yields List<IRenderable>, not IRenderable[]. Also: - Always record results in m_dialogs so --output-file is not empty - Guard empty redirected stdin (DEVNULL IndexOutOfRange) - Skip "Press any key" when stdin is redirected - Skip CanvasImage preview when not interactive Enables Docker/Telegram bots that call SmartImage with --interactive false and a delimited results file.
Owner
|
Thanks for the PR. I'm reviewing it.
This repo doesn't exist? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes three bugs that make SmartImage.Rdx unusable as a headless server backend (Telegram bots, Docker, CI):
(IRenderable[]) listwherelistisIList<IRenderable>/ListfromGetMainRows.--output-file:WriteOutputFileonly walksm_dialogs, which was only populated whenInteractivewas true.ParseInputStream(buffer2[-1]), and ConfirmAsync hanging/crashing on error when stdin is DEVNULL.Test plan
SmartImage photo.jpg -e SauceNao -u Catbox -f Delimited -o out.tsv --interactive false --keep-open false </dev/nullout.tsvhas header + rows when matches existUsed by crl33/ReverseImageSearching Telegram bot behind BotDashboard.