Update documentation and add Torch Profiler SQL support#67
Merged
Conversation
- Added new entries for "Torch Profiler SQL" in the English and Chinese documentation, enhancing the navigation and vocabulary sections. - Introduced a new design document for "Torch Profiler SQL," detailing its functionality and integration with existing profiling tools. - Updated the `mkdocs.yml` configuration to include the new documentation links and ensure proper navigation. - Enhanced the `profiling.md` files to reference the new SQL capabilities, providing users with clearer guidance on using the profiler effectively. These changes aim to improve the clarity and accessibility of the documentation related to the Torch Profiler SQL feature, facilitating better user understanding and adoption.
- Updated the `test_describe_builtin_hccl_via_query_subprocess` to validate catalog rows instead of relying on the `DESCRIBE` command, ensuring tests are more robust against CI subprocess issues. - Modified `test_describe_json_shape_subprocess` to check for `description` and `table_name` columns, enhancing the validation of catalog table documentation. - Removed assertions related to `comment` and `table_comment` to align with the new testing approach. These changes aim to improve the reliability and clarity of the integration tests for the static catalog documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mkdocs.ymlconfiguration to include the new documentation links and ensure proper navigation.profiling.mdfiles to reference the new SQL capabilities, providing users with clearer guidance on using the profiler effectively.These changes aim to improve the clarity and accessibility of the documentation related to the Torch Profiler SQL feature, facilitating better user understanding and adoption.