Skip to content

chore: replace archived upload-release-asset with gh release upload#15110

Merged
Maffooch merged 2 commits into
devfrom
chore/replace-upload-release-asset
Jul 1, 2026
Merged

chore: replace archived upload-release-asset with gh release upload#15110
Maffooch merged 2 commits into
devfrom
chore/replace-upload-release-asset

Conversation

@Maffooch

@Maffooch Maffooch commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Replaces the GitHub-archived actions/upload-release-asset@v1.0.2 in release-drafter.yml, which runs on the deprecated node12 runtime and has no Node 24 release (so it can't be version-bumped — it must be replaced).

The two upload steps are collapsed into a single gh release upload step (GitHub CLI is preinstalled on runners): no action runtime, nothing to pin, and immune to future node deprecation. softprops/action-gh-release@v2 was rejected because it runs on node20 and would re-introduce a soon-deprecated runtime.

The job now surfaces release-drafter's tag_name output (used to target the draft release) instead of the now-unused upload_url. Artifact paths are unchanged; --clobber keeps re-runs idempotent.

Follow-up to the org-wide GitHub Actions cleanup (Node 20 runtime work).

Shortcut: sc-13332

The archived actions/upload-release-asset runs on the node12 runtime and has no Node 24 release. Replace it with a 'gh release upload' step (GitHub CLI, no action runtime) and surface release-drafter's tag_name output.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@Maffooch Maffooch added this to the 3.1.0 milestone Jun 30, 2026
@Maffooch Maffooch requested a review from mtesauro as a code owner June 30, 2026 01:02

@mtesauro mtesauro left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@valentijnscholten

Copy link
Copy Markdown
Member

I have now way of testing this. Did you manage to test it?

@Maffooch

Copy link
Copy Markdown
Contributor Author

I have now way of testing this. Did you manage to test it?

I have used this mechanism in other repos

@Maffooch Maffooch merged commit 528006e into dev Jul 1, 2026
151 checks passed
@Maffooch Maffooch deleted the chore/replace-upload-release-asset branch July 1, 2026 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants