PDF Report: Show vulnerability IDs#15115
Merged
Merged
Conversation
Maffooch
approved these changes
Jul 1, 2026
valentijnscholten
approved these changes
Jul 1, 2026
Jino-T
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #10620.
The finding PDF report table did not show vulnerability IDs, even though other report outputs already include them. This PR adds the missing conditional
Vulnerability IDscolumn to the PDF finding report template and renders the finding's saved vulnerability IDs when present.The PDF report header now includes:
The PDF report data row now includes:
I also added coverage to the existing PDF report rendering tests:
Test results
Ideally you extend the test suite in
tests/anddojo/unitteststo cover the changed in this PR.Alternatively, describe what you have and haven't tested.
Documentation
Passed:
python -m compileall unittests\test_pdf_report_rendering.pyPassed with the existing staticfiles warning for
/app/components/node_modules:docker compose -f docker-compose.yml -f docker-compose.override.unit_tests.yml run --rm --entrypoint "python manage.py check" uwsgiPassed, 7 tests OK:
docker compose -f docker-compose.yml -f docker-compose.override.unit_tests.yml run --rm --entrypoint "python manage.py test unittests.test_pdf_report_rendering.TestPdfReportTextWrapping -v2 --keepdb" uwsgiPassed:
Full local
ruff checkcould not run because localruff 0.15.2does not recognize the repo config selectorPLW0717.Checklist
This checklist is for your information.
dev.dev.bugfixbranch.