Skip to content

Issue #1835 sprinkling from ipf - #1883

Draft
JoerivanEngelen wants to merge 8 commits into
masterfrom
issue_#1835_sprinkling_from_ipf
Draft

Issue #1835 sprinkling from ipf#1883
JoerivanEngelen wants to merge 8 commits into
masterfrom
issue_#1835_sprinkling_from_ipf

Conversation

@JoerivanEngelen

Copy link
Copy Markdown
Contributor

Fixes #1835

Description

Prototype SprinklingPoints class, still TODO:

  • Test if approach works with Peelvenen model
  • Fix two TODOs
  • Add unittests and larger integration/regression/user_acceptance test
  • Remove _scratch.py script, which is used to test locally with Peelvenen model
  • Update changelog

Checklist

  • Links to correct issue
  • Update changelog, if changes affect users
  • PR title starts with Issue #nr, e.g. Issue #737
  • Unit tests were added
  • If feature added: Added/extended example
  • If feature added: Added feature to API documentation
  • If pixi.lock was changed: Ran pixi run generate-sbom and committed changes

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEATURE] - MetaSwapModel.from_imod5_data sprinkling from IPF files

1 participant