feat(api): harden app_user.settings updates against clobbering and races - #984
Open
dembrane-sam-bot wants to merge 1 commit into
Open
feat(api): harden app_user.settings updates against clobbering and races#984dembrane-sam-bot wants to merge 1 commit into
dembrane-sam-bot wants to merge 1 commit into
Conversation
Reject nested settings dictionaries server-side to enforce flatness, and transition to database-level jsonb concatenation (||) via psycopg AsyncConnection to ensure atomicity. Added robust validation and database-level merge tests. Refs: ECHO-931
dembrane-sam-bot
enabled auto-merge
August 10, 2026 18:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this changes
PATCH /v2/menow throws a 400 Bad Request if any nested dict values are passed, enforcing flatness at the server edge and preventing client-side clobbering of sibling attributes —me.py.PATCH /v2/mesettings merge logic from Python-side read-merge-write to atomic Postgresjsonbconcatenation (settings = COALESCE(settings, '{}'::jsonb) || :incoming::jsonb) usingpsycopg'sAsyncConnection. Fallback to safe Directus read-merge-write is gracefully retained if DB connections fail —me.py.psycopg[binary]topyproject.tomldependencies —pyproject.toml.psycopgdatabase updates —test_user_settings_flags.py.Verification
pytest) on/v2/meendpoints: All 4 tests passed successfully with mocked Directus and psycopg connections.Refs: ECHO-931