Skip to content

fix FakeBlockHelper chunk packet byte buffer misalignment #2834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BehrRiley wants to merge 3 commits into
base: dev
Choose a base branch
from
+2 −0
Open

fix FakeBlockHelper chunk packet byte buffer misalignment #2834

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e6ef1b0
fix `FakeBlockHelper` chunk packet byte buffer misalignment
BehrRiley Jul 19, 2026
839437a
Merge branch 'DenizenScript:dev' into feature/fix-26-2-fakeblocks
BehrRiley Jul 20, 2026
9c0ec4d
Merge branch 'DenizenScript:dev' into feature/fix-26-2-fakeblocks
BehrRiley Jul 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .../main/java/com/denizenscript/denizen/nms/v26_2/impl/network/handlers/FakeBlockHelper.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,7 @@ public static ClientboundLevelChunkWithLightPacket handleMapChunkPacket(World wo
Registry<Biome> biomeRegistry = ((CraftWorld) world).getHandle().registryAccess().lookupOrThrow(Registries.BIOME);
for (int y = minChunkY; y < maxChunkY; y++) {
int blockCount = serial.readShort();
int fluidCount = serial.readShort();
// reflected constructors as workaround for spigot remapper bug - Mojang "IdMap" became Spigot "IRegistry" but should be "Registry"
PalettedContainer<BlockState> states = (PalettedContainer<BlockState>) PALETTEDCONTAINER_CTOR.newInstance(Blocks.AIR.defaultBlockState(), Strategy.createForBlockStates(Block.BLOCK_STATE_REGISTRY));
states.read(serial);
Expand Down Expand Up @@ -151,6 +152,7 @@ else if (newState.isAir() && !oldState.isAir()) {
}
}
outputSerial.writeShort(blockCount);
outputSerial.writeShort(fluidCount);
states.write(outputSerial);
biomes.write(outputSerial);
}
Expand Down