Skip to content

Remove unused scripts, deps and obsolete NX targets#34117

Open
alexslavr wants to merge 13 commits into
26_1from
lavrov/remove-obsolete-npm-scripts
Open

Remove unused scripts, deps and obsolete NX targets#34117
alexslavr wants to merge 13 commits into
26_1from
lavrov/remove-obsolete-npm-scripts

Conversation

@alexslavr

@alexslavr alexslavr commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Renovation templates:

Summary of orphan devDependencies dropped:

  • @babel/parser, babel-plugin-add-module-exports
  • @testcafe-community/axe, @testing-library/jest-dom, @testing-library/user-event
  • devextreme-screenshot-comparer, looks-same
  • ast-types, recast
  • autoprefixer, gulp-autoprefixer
  • cldr-numbers-full
  • clean-css, cssom
  • del, fancy-log, map-stream, normalize-path, plugin-error
  • jquery.tmpl, opentype.js
  • nconf, shelljs, staged-git-files, yaml
  • string-replace-loader, stylelint

react-related packages:

  • react, react-dom, react-test-renderer
  • enzyme, enzyme-adapter-react-16

opentype.js was moved to devextreme-scss

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes legacy/unused build-related npm scripts from packages/devextreme/package.json and deletes the obsolete build:dev Nx target from packages/devextreme/project.json to simplify the DevExtreme package’s local/CI command surface.

Changes:

  • Removed the build:dev Nx target from packages/devextreme/project.json.
  • Pruned several packages/devextreme/package.json scripts (dev build/testcafe build, themes/react generation, testing playground, and tcd-update).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/devextreme/project.json Drops the build:dev Nx target (but currently leaves at least one dependent target referencing it).
packages/devextreme/package.json Removes unused/legacy scripts to reduce maintenance overhead.

Comment thread packages/devextreme/project.json Outdated
Copilot AI review requested due to automatic review settings June 25, 2026 09:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot AI review requested due to automatic review settings June 25, 2026 10:08
@alexslavr alexslavr force-pushed the lavrov/remove-obsolete-npm-scripts branch from 39a27f2 to 91e6ded Compare June 25, 2026 10:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread packages/devextreme/project.json
Copilot AI review requested due to automatic review settings June 25, 2026 10:26
@alexslavr alexslavr changed the title Remove unused scripts and obsolete NX targets Remove unused scripts, deps and obsolete NX targets Jun 25, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread packages/devextreme/project.json
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Alex Lavrov <36633600+alexslavr@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 25, 2026 10:32

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread packages/devextreme/package.json
Copilot AI review requested due to automatic review settings June 25, 2026 10:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 8 out of 9 changed files in this pull request and generated 1 comment.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread packages/devextreme/project.json
Copilot AI review requested due to automatic review settings June 25, 2026 11:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Alex Lavrov <36633600+alexslavr@users.noreply.github.com>
Copilot AI review requested due to automatic review settings June 25, 2026 12:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)

packages/devextreme/project.json:1510

  • lint-css target runs the lint-css npm script, but packages/devextreme/package.json does not define a lint-css script anymore. As a result, nx run devextreme:lint-css will fail with “Missing script: lint-css”. If this target is obsolete, it should be removed from the project config (or the script restored along with its toolchain).
    },
    "lint-css": {
      "executor": "nx:run-script",
      "options": {
        "script": "lint-css"

@alexslavr alexslavr requested a review from pharret31 June 25, 2026 13:35
"scripts": {
"clean": "gulp clean",
"lint": "npm-run-all -p -c lint-js lint-ts lint-dts lint-texts",
"lint": "nx run devextreme:lint",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest removing the lint script from package.json and keeping it only in project.json - since it becomes a pure nx thing.

Otherwise, running something like nx run-all -t lint from the root could cause double-wrapping and potentially cause issues on Windows. I'm not entirely certain about this.

The idea is to avoid nesting nx scripts on top of basic npm scripts.
Keeping NX scripts out of package.json seems safer in general, but I don't have concrete evidence yet.

@IlyaKhD IlyaKhD self-requested a review June 25, 2026 13:59
@alexslavr alexslavr added this pull request to the merge queue Jun 25, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants