Remove unused scripts, deps and obsolete NX targets#34117
Conversation
There was a problem hiding this comment.
Pull request overview
Removes legacy/unused build-related npm scripts from packages/devextreme/package.json and deletes the obsolete build:dev Nx target from packages/devextreme/project.json to simplify the DevExtreme package’s local/CI command surface.
Changes:
- Removed the
build:devNx target frompackages/devextreme/project.json. - Pruned several
packages/devextreme/package.jsonscripts (dev build/testcafe build, themes/react generation, testing playground, andtcd-update).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/devextreme/project.json | Drops the build:dev Nx target (but currently leaves at least one dependent target referencing it). |
| packages/devextreme/package.json | Removes unused/legacy scripts to reduce maintenance overhead. |
39a27f2 to
91e6ded
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Alex Lavrov <36633600+alexslavr@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: Alex Lavrov <36633600+alexslavr@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 10 changed files in this pull request and generated no new comments.
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Comments suppressed due to low confidence (1)
packages/devextreme/project.json:1510
lint-csstarget runs thelint-cssnpm script, butpackages/devextreme/package.jsondoes not define alint-cssscript anymore. As a result,nx run devextreme:lint-csswill fail with “Missing script: lint-css”. If this target is obsolete, it should be removed from the project config (or the script restored along with its toolchain).
},
"lint-css": {
"executor": "nx:run-script",
"options": {
"script": "lint-css"
| "scripts": { | ||
| "clean": "gulp clean", | ||
| "lint": "npm-run-all -p -c lint-js lint-ts lint-dts lint-texts", | ||
| "lint": "nx run devextreme:lint", |
There was a problem hiding this comment.
I'd suggest removing the lint script from package.json and keeping it only in project.json - since it becomes a pure nx thing.
Otherwise, running something like nx run-all -t lint from the root could cause double-wrapping and potentially cause issues on Windows. I'm not entirely certain about this.
The idea is to avoid nesting nx scripts on top of basic npm scripts.
Keeping NX scripts out of package.json seems safer in general, but I don't have concrete evidence yet.
Renovation templates:
Summary of orphan devDependencies dropped:
react-related packages:
opentype.jswas moved todevextreme-scss