Harden block render escaping and validate attributes before GitHub API calls#15
Open
mathetos wants to merge 1 commit into
Open
Harden block render escaping and validate attributes before GitHub API calls#15mathetos wants to merge 1 commit into
mathetos wants to merge 1 commit into
Conversation
…I calls Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #16
Summary
Hardens
src/Block.phpoutput escaping and attribute handling before GitHub API requests.esc_html_e()usage on dynamic API values withesc_html(),esc_url(), andesc_attr()as appropriatesanitize_attributes()forprofileName,repoUrl,mediaUrl, and related block fields before fetch/renderfetchData()and detect them reliably inget_output_or_error()md5()to avoid odd characters in option namesTest plan
Octocatand confirm profile + repo list render