Skip to content

Add press atomic action#317

Merged
skywhite1024 merged 2 commits into
mainfrom
ljd/press_atomic_actions
Jul 1, 2026
Merged

Add press atomic action#317
skywhite1024 merged 2 commits into
mainfrom
ljd/press_atomic_actions

Conversation

@skywhite1024

@skywhite1024 skywhite1024 commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR adds the Press atomic action to the atomic action system.

It includes:

  • PressAction and PressActionCfg registration/export support
  • a Press tutorial script under scripts/tutorials/atomic_action/press.py
  • unit coverage for Press action construction and execution flow
  • documentation updates for the built-in atomic actions page
  • a Press demo gif for the docs

Dependencies: None.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking change which improves an existing functionality)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (existing functionality will not work without user modification)
  • Documentation update

Screenshots

Press demo gif is added at:

docs/source/_static/atomic_actions/press.gif

Validation

  • black --check --diff --color embodichain/lab/sim/atomic_actions/actions.py embodichain/lab/sim/atomic_actions/__init__.py scripts/tutorials/atomic_action/press.py tests/sim/atomic_actions/test_actions.py
  • python -m pytest tests/sim/atomic_actions/test_actions.py
  • python -m pytest tests/sim/planners/test_motion_generator.py
  • python -m pytest tests/sim/atomic_actions/test_actions.py tests/sim/planners/test_motion_generator.py

Checklist

  • I have run formatting checks.
  • I have made corresponding changes to the documentation.
  • I have added tests that prove the feature works.
  • Dependencies have been updated, if applicable.

@skywhite1024 skywhite1024 changed the base branch from ljd/move_object_atomic_actions to refactor/atomic-actions-redesign June 23, 2026 12:41
@skywhite1024 skywhite1024 force-pushed the ljd/press_atomic_actions branch from 686e6ed to e513db6 Compare June 24, 2026 04:20
Base automatically changed from refactor/atomic-actions-redesign to main June 25, 2026 06:08
@skywhite1024 skywhite1024 force-pushed the ljd/press_atomic_actions branch 2 times, most recently from 2e5798e to c8c6079 Compare June 25, 2026 08:10
Comment thread docs/source/overview/sim/atomic_actions/builtin_actions.md Outdated
Comment thread scripts/tutorials/atomic_action/press.py
@yuecideng yuecideng changed the title Add press atomic action Add press atomic action and release skill Jun 25, 2026
@yuecideng yuecideng added docs Improvements or additions to documentation motion gen Things related to motion generation for robot labels Jun 25, 2026
@skywhite1024 skywhite1024 force-pushed the ljd/press_atomic_actions branch from e2cd03b to 3ceb472 Compare June 26, 2026 03:17
@skywhite1024 skywhite1024 changed the title Add press atomic action and release skill Add press atomic action Jun 26, 2026
@skywhite1024 skywhite1024 added the enhancement New feature or request label Jun 26, 2026
@skywhite1024 skywhite1024 force-pushed the ljd/press_atomic_actions branch from 3ceb472 to 3e48aa6 Compare July 1, 2026 07:09
Copilot AI review requested due to automatic review settings July 1, 2026 07:09

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a new Press atomic action to EmbodiChain’s atomic action system, including the action/config implementation, exports, a tutorial demo script, tests, and documentation updates so the primitive is discoverable and usable end-to-end.

Changes:

  • Implemented and exported Press / PressCfg as a new built-in atomic action.
  • Added a press.py tutorial script demonstrating planning and replaying a press interaction.
  • Extended unit tests and updated Sphinx docs pages to include Press in the built-in action set.

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
embodichain/lab/sim/atomic_actions/actions.py Adds PressCfg and the Press action implementation and exports.
embodichain/lab/sim/atomic_actions/__init__.py Re-exports Press / PressCfg from the package top-level.
scripts/tutorials/atomic_action/press.py New tutorial/demo script exercising Press via AtomicActionEngine.
tests/sim/atomic_actions/test_actions.py Adds unit coverage for Press construction and execution behavior.
docs/source/tutorial/atomic_actions.rst Updates tutorial index to include the new press.py demo.
docs/source/overview/sim/atomic_actions/index.md Updates overview docs to list Press as accepting EndEffectorPoseTarget and shows example registration.
docs/source/overview/sim/atomic_actions/builtin_actions.md Adds Press to the built-in actions table and documents its phases/config/target.
docs/source/api_reference/embodichain/embodichain.lab.sim.atomic_actions.rst Adds API reference entries for Press and PressCfg.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@skywhite1024 skywhite1024 force-pushed the ljd/press_atomic_actions branch from 3e48aa6 to f43252e Compare July 1, 2026 07:21
@skywhite1024 skywhite1024 merged commit 2127f3d into main Jul 1, 2026
5 checks passed
@skywhite1024 skywhite1024 deleted the ljd/press_atomic_actions branch July 1, 2026 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Improvements or additions to documentation enhancement New feature or request motion gen Things related to motion generation for robot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants