Add press atomic action#317
Merged
Merged
Conversation
686e6ed to
e513db6
Compare
2e5798e to
c8c6079
Compare
yuecideng
reviewed
Jun 25, 2026
yuecideng
reviewed
Jun 25, 2026
e2cd03b to
3ceb472
Compare
3ceb472 to
3e48aa6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds a new Press atomic action to EmbodiChain’s atomic action system, including the action/config implementation, exports, a tutorial demo script, tests, and documentation updates so the primitive is discoverable and usable end-to-end.
Changes:
- Implemented and exported
Press/PressCfgas a new built-in atomic action. - Added a
press.pytutorial script demonstrating planning and replaying a press interaction. - Extended unit tests and updated Sphinx docs pages to include
Pressin the built-in action set.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
embodichain/lab/sim/atomic_actions/actions.py |
Adds PressCfg and the Press action implementation and exports. |
embodichain/lab/sim/atomic_actions/__init__.py |
Re-exports Press / PressCfg from the package top-level. |
scripts/tutorials/atomic_action/press.py |
New tutorial/demo script exercising Press via AtomicActionEngine. |
tests/sim/atomic_actions/test_actions.py |
Adds unit coverage for Press construction and execution behavior. |
docs/source/tutorial/atomic_actions.rst |
Updates tutorial index to include the new press.py demo. |
docs/source/overview/sim/atomic_actions/index.md |
Updates overview docs to list Press as accepting EndEffectorPoseTarget and shows example registration. |
docs/source/overview/sim/atomic_actions/builtin_actions.md |
Adds Press to the built-in actions table and documents its phases/config/target. |
docs/source/api_reference/embodichain/embodichain.lab.sim.atomic_actions.rst |
Adds API reference entries for Press and PressCfg. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
3e48aa6 to
f43252e
Compare
yuecideng
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the Press atomic action to the atomic action system.
It includes:
PressActionandPressActionCfgregistration/export supportscripts/tutorials/atomic_action/press.pyDependencies: None.
Type of change
Screenshots
Press demo gif is added at:
docs/source/_static/atomic_actions/press.gifValidation
black --check --diff --color embodichain/lab/sim/atomic_actions/actions.py embodichain/lab/sim/atomic_actions/__init__.py scripts/tutorials/atomic_action/press.py tests/sim/atomic_actions/test_actions.pypython -m pytest tests/sim/atomic_actions/test_actions.pypython -m pytest tests/sim/planners/test_motion_generator.pypython -m pytest tests/sim/atomic_actions/test_actions.py tests/sim/planners/test_motion_generator.pyChecklist