Add i06-1 magnets - #2115
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2115 +/- ##
==========================================
+ Coverage 99.16% 99.18% +0.02%
==========================================
Files 353 360 +7
Lines 13877 14296 +419
==========================================
+ Hits 13761 14180 +419
Misses 116 116 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…/dodal into add_i06_magnets
Relm-Arrowny
left a comment
There was a problem hiding this comment.
I gone through it roughly, I have a few questions
Relm-Arrowny
left a comment
There was a problem hiding this comment.
The core logic for movement strategies and mode boundary enforcement looks great! I still feel we should make MagnetAxis a pure StandardReadable so we do not bypass the controller's safety logic and eliminates the need to inject mag_within_boundary callbacks into MagnetAxis.
I know you might not be fully convinced t about keeping MagnetAxis read-only and I probably did not explain it well. If you're busy or would prefer, I'm happy to take a stab at the branch to refactor MagnetAxis, and the controller to show you what I had in mind!
…hecked at each step
Removing review block due to unresolved design impasse around coupling and hardcoded safety limits.
…/dodal into add_i06_magnets
Relm-Arrowny
left a comment
There was a problem hiding this comment.
Looks great! Thanks for pushing this update—the multi-axis movement strategy delegation and fly-scan protocols look super clean and well-structured.
Before hitting merge, I went ahead and added a quick minor safety tweaks:
Default Timeout on _trigger_ramp(): Added a fallback safety timeout (timeout=500.0) when waiting for RAMP_MADE so Bluesky plans won't hang indefinitely if the IOC stalls.
|
DiamondLightSource/sm-bluesky#356 |
Fixes #2120
This add the basic device layer and control structures for the I06-1 superconducting vector magnet. It implements coordinate transformations, safe coordinated multi-axis moves, and support single axis x, y, z flyscan.
Changes
Instructions to reviewer on how to test:
dodal connect i06-1Checks for reviewer
dodal connect ${BEAMLINE}